Bug 188204

Summary: Add TransformationMatrix::Identity
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, simon.fraser
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Yusuke Suzuki
Reported 2018-07-31 12:42:51 PDT
Add TransformationMatrix::Identity
Attachments
Patch (3.43 KB, patch)
2018-07-31 12:43 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (3.48 KB, patch)
2018-08-01 01:23 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2018-07-31 12:43:38 PDT
Created attachment 346191 [details] Patch
Yusuke Suzuki
Comment 2 2018-08-01 01:23:18 PDT
Created attachment 346265 [details] Patch
Yusuke Suzuki
Comment 3 2018-08-01 08:33:55 PDT
Comment on attachment 346265 [details] Patch Thanks
WebKit Commit Bot
Comment 4 2018-08-01 09:01:07 PDT
Comment on attachment 346265 [details] Patch Clearing flags on attachment: 346265 Committed r234460: <https://trac.webkit.org/changeset/234460>
WebKit Commit Bot
Comment 5 2018-08-01 09:01:09 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 6 2018-08-01 09:55:26 PDT
Comment on attachment 346265 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346265&action=review > Source/WebCore/platform/graphics/transforms/TransformationMatrix.h:121 > + static const TransformationMatrix Identity; Seems fine to define this, but unclear to me why its name is capitalized given WebKit coding style.
Radar WebKit Bug Importer
Comment 7 2018-08-01 20:34:52 PDT
<rdar://problem/42840494>
Yusuke Suzuki
Comment 8 2018-08-01 20:40:14 PDT
Comment on attachment 346265 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346265&action=review >> Source/WebCore/platform/graphics/transforms/TransformationMatrix.h:121 >> + static const TransformationMatrix Identity; > > Seems fine to define this, but unclear to me why its name is capitalized given WebKit coding style. Ah, I named it as `Identity` since we have `JSCell::StructureFlags` static const variable, but it seems this is rather exceptional. Changed in a follow-up patch.
Yusuke Suzuki
Comment 9 2018-08-01 21:10:48 PDT
Committed r234492: <https://trac.webkit.org/changeset/234492>
Note You need to log in before you can comment on or make changes to this bug.