Bug 188203

Summary:

Hardcode some system colors to avoid fingerprinting exposure

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

CSS

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, bfulgham, commit-queue, ews-watchlist, ggaren, ie2kl43y, megan_gardner, rniwa, thorton, webkit-bug-importer, wilander

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=210719

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews103 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Archive of layout-test-results from ews117 for mac-sierra	none
Patch	none
Archive of layout-test-results from ews100 for mac-sierra	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
Archive of layout-test-results from ews117 for mac-sierra	none
Patch	none

Timothy Hatcher

Reported 2018-07-31 12:05:58 PDT

Don't expose system colors that are based on user appearance preference.

Attachments
Patch (8.81 KB, patch) 2018-07-31 12:07 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-sierra (2.32 MB, application/zip) 2018-07-31 13:14 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.84 MB, application/zip) 2018-07-31 13:21 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-sierra (3.05 MB, application/zip) 2018-07-31 15:17 PDT, EWS Watchlist	no flags	Details
Patch (14.64 KB, patch) 2018-07-31 15:19 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-sierra (2.38 MB, application/zip) 2018-07-31 16:26 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (2.81 MB, application/zip) 2018-07-31 16:31 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews117 for mac-sierra (3.18 MB, application/zip) 2018-07-31 16:44 PDT, EWS Watchlist	no flags	Details
Patch (17.86 KB, patch) 2018-07-31 20:55 PDT, Timothy Hatcher	no flags	Details Formatted Diff Diff
Show Obsolete (8) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-07-31 12:06:16 PDT

<rdar://problem/42781630>

Timothy Hatcher

Comment 2 2018-07-31 12:07:45 PDT Comment hidden (obsolete)

Created attachment 346186 [details] Patch

Tim Horton

Comment 3 2018-07-31 12:38:06 PDT

Comment on attachment 346186 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346186&action=review > Source/WebCore/rendering/RenderThemeMac.mm:761 > + return 0xFF7DADD9; We can’t get these un-accented from the system?

Timothy Hatcher

Comment 4 2018-07-31 13:02:33 PDT

Comment on attachment 346186 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346186&action=review >> Source/WebCore/rendering/RenderThemeMac.mm:761 >> + return 0xFF7DADD9; > > We can’t get these un-accented from the system? Not that I could find.

EWS Watchlist

Comment 5 2018-07-31 13:14:27 PDT Comment hidden (obsolete)

Comment on attachment 346186 [details] Patch Attachment 346186 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8713260 New failing tests: fast/css/apple-system-control-colors.html css3/color-filters/color-filter-ignore-semantic.html

EWS Watchlist

Comment 6 2018-07-31 13:14:29 PDT Comment hidden (obsolete)

Created attachment 346194 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 7 2018-07-31 13:21:55 PDT Comment hidden (obsolete)

Comment on attachment 346186 [details] Patch Attachment 346186 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8713312 New failing tests: fast/css/apple-system-control-colors.html css3/color-filters/color-filter-ignore-semantic.html

EWS Watchlist

Comment 8 2018-07-31 13:21:56 PDT Comment hidden (obsolete)

Created attachment 346196 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 9 2018-07-31 15:17:46 PDT Comment hidden (obsolete)

Comment on attachment 346186 [details] Patch Attachment 346186 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8714356 New failing tests: fast/css/apple-system-control-colors.html css3/color-filters/color-filter-ignore-semantic.html

EWS Watchlist

Comment 10 2018-07-31 15:17:47 PDT Comment hidden (obsolete)

Created attachment 346209 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6

Timothy Hatcher

Comment 11 2018-07-31 15:19:08 PDT Comment hidden (obsolete)

Created attachment 346210 [details] Patch

EWS Watchlist

Comment 12 2018-07-31 16:26:38 PDT Comment hidden (obsolete)

Comment on attachment 346210 [details] Patch Attachment 346210 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8715603 New failing tests: fast/css/apple-system-control-colors.html fast/css/test-setting-canvas-color.html

EWS Watchlist

Comment 13 2018-07-31 16:26:40 PDT Comment hidden (obsolete)

Created attachment 346218 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 14 2018-07-31 16:31:45 PDT Comment hidden (obsolete)

Comment on attachment 346210 [details] Patch Attachment 346210 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8715638 New failing tests: fast/css/apple-system-control-colors.html fast/css/test-setting-canvas-color.html

EWS Watchlist

Comment 15 2018-07-31 16:31:47 PDT Comment hidden (obsolete)

Created attachment 346219 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 16 2018-07-31 16:44:31 PDT Comment hidden (obsolete)

Comment on attachment 346210 [details] Patch Attachment 346210 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8715558 New failing tests: fast/css/apple-system-control-colors.html fast/css/test-setting-canvas-color.html

EWS Watchlist

Comment 17 2018-07-31 16:44:33 PDT Comment hidden (obsolete)

Created attachment 346221 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6

Timothy Hatcher

Comment 18 2018-07-31 20:55:59 PDT

Created attachment 346254 [details] Patch

Tim Horton

Comment 19 2018-08-01 11:40:38 PDT

Comment on attachment 346254 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346254&action=review > Source/WebCore/rendering/RenderThemeMac.mm:768 > + return Color(0x4C1AA9FF, Color::Semantic); You could neaten this up with the ternary operator but maybe this is easier to read.

WebKit Commit Bot

Comment 20 2018-08-01 12:07:49 PDT

Comment on attachment 346254 [details] Patch Clearing flags on attachment: 346254 Committed r234466: <https://trac.webkit.org/changeset/234466>

WebKit Commit Bot

Comment 21 2018-08-01 12:07:51 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.