Bug 188194

Summary: [GStreamer] Dynamically adjust blocksize
Product: WebKit Reporter: Charlie Turner <cturner>
Component: WebKitGTKAssignee: Charlie Turner <cturner>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=188193
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Charlie Turner
Reported 2018-07-31 06:50:57 PDT
[GStreamer] Dynamically adjust blocksize
Attachments
Patch (5.94 KB, patch)
2018-07-31 06:53 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Patch (5.96 KB, patch)
2018-08-02 04:38 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Patch (5.98 KB, patch)
2018-08-02 04:40 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Charlie Turner
Comment 1 2018-07-31 06:53:48 PDT
Created attachment 346165 [details] Patch
Charlie Turner
Comment 2 2018-07-31 06:54:21 PDT
Depends on https://bugs.webkit.org/show_bug.cgi?id=188193 landing first.
Xabier Rodríguez Calvar
Comment 3 2018-08-01 00:01:29 PDT
Comment on attachment 346165 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346165&action=review > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:60 > + static constexpr int growBlocksizeLimit { 1 }; > + static constexpr int growBlocksizeCount { 1 }; > + static constexpr int growBlocksizeFactor { 2 }; > + static constexpr float reduceBlocksizeLimit { 0.20 }; > + static constexpr int reduceBlocksizeCount { 2 }; > + static constexpr float reduceBlocksizeFactor { 0.5 }; These should be prefixed with s_ > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:784 > + m_reduceBlocksizeCount = m_increaseBlocksizeCount = 0; Please, write this in two lines.
Charlie Turner
Comment 4 2018-08-02 04:38:32 PDT
Created attachment 346374 [details] Patch Fix code style violations
Charlie Turner
Comment 5 2018-08-02 04:40:26 PDT
Created attachment 346375 [details] Patch Fix code style violations
WebKit Commit Bot
Comment 6 2018-08-02 05:22:00 PDT
Comment on attachment 346375 [details] Patch Clearing flags on attachment: 346375 Committed r234498: <https://trac.webkit.org/changeset/234498>
WebKit Commit Bot
Comment 7 2018-08-02 05:22:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.