Summary: | Add missing CoreGraphics SPI | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||
Component: | WebKit Misc. | Assignee: | Devin Rousso <hi> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cdumez, commit-queue, joepeck, pvollan, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Created attachment 346082 [details]
Patch
Comment on attachment 346082 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346082&action=review r=me > Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:305 > +#if ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) You could probably drop the `ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)` if/endifs. This SPI exists on Mac, regardless of whether or not we decide to use it based on this feature. Comment on attachment 346082 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346082&action=review >> Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:305 >> +#if ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) > > You could probably drop the `ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)` if/endifs. This SPI exists on Mac, regardless of whether or not we decide to use it based on this feature. I did this to follow it's usage in WebProcessCocoa.mm. I built it once without it and there was no issue, but I figured it couldn't hurt to match. Comment on attachment 346082 [details] Patch Clearing flags on attachment: 346082 Committed r234382: <https://trac.webkit.org/changeset/234382> All reviewed patches have been landed. Closing bug. |
From error when building: > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:319:5: error: use of undeclared identifier 'CGSSetDenyWindowServerConnections'