Bug 188177

Summary: Add missing CoreGraphics SPI
Product: WebKit Reporter: Devin Rousso <hi>
Component: WebKit Misc.Assignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, joepeck, pvollan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2018-07-30 12:18:01 PDT
From error when building: > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:319:5: error: use of undeclared identifier 'CGSSetDenyWindowServerConnections'
Attachments
Patch (2.38 KB, patch)
2018-07-30 12:20 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-07-30 12:20:27 PDT
Created attachment 346082 [details] Patch
Joseph Pecoraro
Comment 2 2018-07-30 12:24:22 PDT
Comment on attachment 346082 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346082&action=review r=me > Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:305 > +#if ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) You could probably drop the `ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)` if/endifs. This SPI exists on Mac, regardless of whether or not we decide to use it based on this feature.
Devin Rousso
Comment 3 2018-07-30 12:34:18 PDT
Comment on attachment 346082 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346082&action=review >> Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:305 >> +#if ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) > > You could probably drop the `ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)` if/endifs. This SPI exists on Mac, regardless of whether or not we decide to use it based on this feature. I did this to follow it's usage in WebProcessCocoa.mm. I built it once without it and there was no issue, but I figured it couldn't hurt to match.
WebKit Commit Bot
Comment 4 2018-07-30 13:38:27 PDT
Comment on attachment 346082 [details] Patch Clearing flags on attachment: 346082 Committed r234382: <https://trac.webkit.org/changeset/234382>
WebKit Commit Bot
Comment 5 2018-07-30 13:38:28 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-07-30 13:39:22 PDT
<rdar://problem/42744931>
Note You need to log in before you can comment on or make changes to this bug.