Bug 188175

Summary:

[Win] Implement Image::loadPlatformResource

Product:

WebKit

Reporter:

Stephan Szabo <stephan.szabo>

Component:

WebKit Misc.

Assignee:

Fujii Hironori <Hironori.Fujii>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, eric.carlson, ews-watchlist, glenn, gyuyoung.kim, Hironori.Fujii, jer.noble, philipj, pvollan, ryuan.choi, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

232062

Attachments:

Description	Flags
Add and load image resources	none
Add and load image resources	ews-watchlist: commit-queue-
Archive of layout-test-results from ews200 for win-future	none
Patch for checking on ews	ews-feeder: commit-queue-
WIP patch	none

Stephan Szabo

Reported 2018-07-30 10:35:06 PDT

The search magnifying glass and <x> erase search term icons are not displayed.

Attachments
Add and load image resources (21.28 KB, patch) 2018-08-03 14:26 PDT, Stephan Szabo	no flags	Details Formatted Diff Diff
Add and load image resources (109.44 KB, patch) 2018-08-03 14:30 PDT, Stephan Szabo	ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews200 for win-future (13.01 MB, application/zip) 2018-08-03 17:11 PDT, EWS Watchlist	no flags	Details
Patch for checking on ews (26.24 KB, patch) 2021-01-20 09:33 PST, Stephan Szabo	ews-feeder: commit-queue-	Details Formatted Diff Diff
WIP patch (1.20 KB, patch) 2023-02-13 17:29 PST, Fujii Hironori	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Stephan Szabo

Comment 1 2018-08-03 14:26:58 PDT

Created attachment 346547 [details] Add and load image resources resource.h doesn't fit the style guidelines as it's made by visual studio.

Stephan Szabo

Comment 2 2018-08-03 14:30:55 PDT

Created attachment 346550 [details] Add and load image resources

EWS Watchlist

Comment 3 2018-08-03 14:32:22 PDT

Attachment 346550 [details] did not pass style-queue: ERROR: Source/WebKit/Platform/win/resource.h:0: No copyright message found. You should have a line: "Copyright [year] <Copyright Owner>" [legal/copyright] [5] ERROR: Source/WebKit/Platform/win/resource.h:1: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 4 2018-08-03 17:11:00 PDT

Comment on attachment 346550 [details] Add and load image resources Attachment 346550 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8755924 New failing tests: http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html

EWS Watchlist

Comment 5 2018-08-03 17:11:11 PDT

Created attachment 346565 [details] Archive of layout-test-results from ews200 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews200 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Fujii Hironori

Comment 6 2018-08-05 19:22:12 PDT

You copy the icons and the implentation of loadResourceIntoBuffer from WebKitLegacy. There is a comment. https://github.com/WebKit/webkit/blob/c4b88ee56e4f77201ffdcaf6a5988cbc43e199f3/Source/WebKitLegacy/win/WebKitDLL.cpp#L171 > //FIXME: We should consider moving this to a new file for cross-project functionality It seems that it is the time to fix this. You should have a discussion with AppleWin port forks.

Stephan Szabo

Comment 7 2021-01-20 09:33:06 PST

Created attachment 417976 [details] Patch for checking on ews Initial checking EWS patch for moving resource loading code up into WebCore (so no changelog or the like).

Fujii Hironori

Comment 8 2021-10-20 17:56:53 PDT

Don added a dependency to Bug 232062 for this. But, I don't like the idea Bug 232062 just for this. Let's take the original Steph's approach copying images (attachment#346550 [details]).

Don Olmstead

Comment 9 2022-06-21 22:05:43 PDT

Pull request: https://github.com/WebKit/WebKit/pull/1672

Fujii Hironori

Comment 10 2023-02-13 17:08:24 PST

255715@main (bug#246604) switched WinCairo to use RenderThemeAdwaita instead of RenderThemeWin. searchCancel, searchCancelPressed and searchMagnifier were used only by RenderThemeWin.

Fujii Hironori

Comment 11 2023-02-13 17:19:53 PST

We should use icons in https://github.com/WebKit/WebKit/tree/main/Source/WebCore/Resources .

Fujii Hironori

Comment 12 2023-02-13 17:29:47 PST

Created attachment 464978 [details] WIP patch I prefer an approach simply loading icons from a file like media control resources. I don't want to edit a resource file.

Fujii Hironori

Comment 13 2023-03-07 18:47:00 PST

Pull request: https://github.com/WebKit/WebKit/pull/11211

EWS

Comment 14 2023-03-13 23:44:38 PDT

Committed 261615@main (77fc48384711): <https://commits.webkit.org/261615@main> Reviewed commits have been landed. Closing PR #11211 and removing active labels.

Radar WebKit Bug Importer

Comment 15 2023-03-13 23:45:19 PDT

<rdar://problem/106685269>

Note You need to log in before you can comment on or make changes to this bug.