Bug 188173

Summary: Rename some JSC API functions/types.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, ggaren, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Keith Miller
Reported 2018-07-30 10:33:40 PDT
Rename some JSC API functions/types.
Attachments
Patch (17.67 KB, patch)
2018-07-30 10:34 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2018-07-30 10:34:40 PDT
Created attachment 346068 [details] Patch
EWS Watchlist
Comment 2 2018-07-30 10:36:35 PDT
Attachment 346068 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/API/JSObjectRef.h:565: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:577: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:590: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:590: The parameter name "value" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:590: The parameter name "attributes" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/JavaScriptCore/API/JSObjectRef.h:602: The parameter name "object" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 6 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2018-07-30 13:13:44 PDT
Comment on attachment 346068 [details] Patch Clearing flags on attachment: 346068 Committed r234381: <https://trac.webkit.org/changeset/234381>
WebKit Commit Bot
Comment 4 2018-07-30 13:13:45 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-07-30 13:14:18 PDT
<rdar://problem/42743967>
Note You need to log in before you can comment on or make changes to this bug.