Bug 188173 - Rename some JSC API functions/types.
Summary: Rename some JSC API functions/types.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-30 10:33 PDT by Keith Miller
Modified: 2018-07-30 13:14 PDT (History)
7 users (show)

See Also:

Attachments
Patch (17.67 KB, patch)
2018-07-30 10:34 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2018-07-30 10:33:40 PDT 
Rename some JSC API functions/types.
Comment 1 Keith Miller 2018-07-30 10:34:40 PDT 
Created attachment 346068 [details]
Patch
Comment 2 EWS Watchlist 2018-07-30 10:36:35 PDT 
Attachment 346068 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/API/JSObjectRef.h:565:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRef.h:577:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRef.h:590:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRef.h:590:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRef.h:590:  The parameter name "attributes" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/API/JSObjectRef.h:602:  The parameter name "object" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 6 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2018-07-30 13:13:44 PDT 
Comment on attachment 346068 [details]
Patch

Clearing flags on attachment: 346068

Committed r234381: <https://trac.webkit.org/changeset/234381>
Comment 4 WebKit Commit Bot 2018-07-30 13:13:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-07-30 13:14:18 PDT 
<rdar://problem/42743967>