| Summary: | Make CompositeOperator and BlendMode into 8-bit enum classes | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||||||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||||||||||||||||
| Status: | RESOLVED DUPLICATE | ||||||||||||||||||||||||
| Severity: | Normal | CC: | achristensen, darin, ews-watchlist, rniwa, simon.fraser | ||||||||||||||||||||||
| Priority: | P2 | ||||||||||||||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||
| Bug Depends on: | 186751 | ||||||||||||||||||||||||
| Bug Blocks: | |||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||
|
Description
Simon Fraser (smfr)
2018-07-29 08:28:50 PDT
Created attachment 346029 [details]
Patch
Comment on attachment 346029 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346029&action=review > Source/WebCore/html/HTMLImageElement.cpp:70 > + , m_compositeOperator(CompositeOperator::SourceOver) Do this in the header instead? > Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:202 > + , globalComposite(CompositeOperator::SourceOver) > + , globalBlend(BlendMode::Normal) Do these in the class definition instead of the constructor? Created attachment 346063 [details]
Patch
Created attachment 346064 [details]
Patch
Created attachment 346065 [details]
Patch
Comment on attachment 346065 [details] Patch Attachment 346065 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8700661 New failing tests: svg/dom/SVGAnimatedEnumeration-case-sensitive.html svg/animations/svgenum-animation-11.html svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html Created attachment 346077 [details]
Archive of layout-test-results from ews103 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
SVG tests are failing because:
template<typename EnumType>
class SVGAnimatedEnumerationPropertyTearOff final : public SVGAnimatedStaticPropertyTearOff<unsigned> {
fails badly if EnumType is 8-bit; we're casting an 8-bit enum to unsigned and taking a reference
Comment on attachment 346065 [details] Patch Attachment 346065 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8700709 New failing tests: svg/dom/SVGAnimatedEnumeration-case-sensitive.html svg/animations/svgenum-animation-11.html svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html Created attachment 346079 [details]
Archive of layout-test-results from ews113 for mac-sierra
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 346065 [details] Patch Attachment 346065 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8700818 New failing tests: svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html svg/dom/SVGAnimatedEnumeration-case-sensitive.html svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html Created attachment 346083 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Comment on attachment 346065 [details] Patch Attachment 346065 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8702131 New failing tests: css3/filters/backdrop/add-remove-add-backdrop-filter.html svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html svg/dom/SVGAnimatedEnumeration-case-sensitive.html svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html svg/animations/svgenum-animation-11.html Created attachment 346094 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 346065 [details] Patch Attachment 346065 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8702368 New failing tests: svg/dom/SVGAnimatedEnumeration-case-sensitive.html svg/animations/svgenum-animation-11.html svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html Created attachment 346098 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 346065 [details] Patch Attachment 346065 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8702250 New failing tests: svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop.html svg/dom/SVGAnimatedEnumeration-case-sensitive.html svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html Created attachment 346099 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
*** This bug has been marked as a duplicate of bug 188325 *** |