Bug 188143

Summary:

Shrink GraphicsLayer by making m_transform and m_childrenTransform be unique_ptrs

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, dino, ews-watchlist, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews102 for mac-sierra	none
Archive of layout-test-results from ews107 for mac-sierra-wk2	none
Patch	none
Patch	zalan: review+

Simon Fraser (smfr)

Reported 2018-07-28 21:54:30 PDT

Shrink GraphicsLayer by making m_transform and m_childrenTransform be unique_ptrs

Attachments
Patch (11.80 KB, patch) 2018-07-28 21:56 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-sierra (2.36 MB, application/zip) 2018-07-28 23:05 PDT, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.84 MB, application/zip) 2018-07-28 23:12 PDT, EWS Watchlist	no flags	Details
Patch (11.81 KB, patch) 2018-07-29 08:46 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Patch (12.38 KB, patch) 2018-07-29 09:57 PDT, Simon Fraser (smfr)	zalan: review+	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2018-07-28 21:56:26 PDT

Created attachment 346010 [details] Patch

Darin Adler

Comment 2 2018-07-28 22:14:11 PDT

Comment on attachment 346010 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346010&action=review > Source/WebCore/platform/graphics/GraphicsLayer.cpp:297 > + NeverDestroyed<TransformationMatrix> identityTransform; Need a "static" here!

EWS Watchlist

Comment 3 2018-07-28 23:05:19 PDT Comment hidden (obsolete)

Comment on attachment 346010 [details] Patch Attachment 346010 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8688282 New failing tests: compositing/masks/tiled-mask.html css3/filters/backdrop/effect-hw.html

EWS Watchlist

Comment 4 2018-07-28 23:05:21 PDT Comment hidden (obsolete)

Created attachment 346013 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 5 2018-07-28 23:12:35 PDT Comment hidden (obsolete)

Comment on attachment 346010 [details] Patch Attachment 346010 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8688291 New failing tests: compositing/masks/tiled-mask.html css3/filters/backdrop/effect-hw.html

EWS Watchlist

Comment 6 2018-07-28 23:12:37 PDT Comment hidden (obsolete)

Created attachment 346014 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

Simon Fraser (smfr)

Comment 7 2018-07-29 08:46:05 PDT

Created attachment 346032 [details] Patch

Simon Fraser (smfr)

Comment 8 2018-07-29 09:57:30 PDT

Created attachment 346033 [details] Patch

Simon Fraser (smfr)

Comment 9 2018-07-30 09:38:02 PDT

https://trac.webkit.org/changeset/234368/webkit

Radar WebKit Bug Importer

Comment 10 2018-07-30 09:43:03 PDT

<rdar://problem/42735167>

Note You need to log in before you can comment on or make changes to this bug.