Bug 188143 – Shrink GraphicsLayer by making m_transform and m_childrenTransform be unique_ptrs

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Shrink GraphicsLayer by making m_transform and m_childrenTransform be unique_ptrs

[Simon Fraser (smfr)]

Created attachment 346010 [details]
Patch

[Darin Adler]

Comment on attachment 346010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346010&action=review

> Source/WebCore/platform/graphics/GraphicsLayer.cpp:297
> +    NeverDestroyed<TransformationMatrix> identityTransform;

Need a "static" here!

[EWS Watchlist]

Comment on attachment 346010 [details]
Patch

Attachment 346010 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/8688282

New failing tests:
compositing/masks/tiled-mask.html
css3/filters/backdrop/effect-hw.html

[EWS Watchlist]

Created attachment 346013 [details]
Archive of layout-test-results from ews102 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-sierra  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 346010 [details]
Patch

Attachment 346010 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8688291

New failing tests:
compositing/masks/tiled-mask.html
css3/filters/backdrop/effect-hw.html

[EWS Watchlist]

Created attachment 346014 [details]
Archive of layout-test-results from ews107 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

[Simon Fraser (smfr)]

Created attachment 346032 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 346033 [details]
Patch

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/234368/webkit

[Radar WebKit Bug Importer]

<rdar://problem/42735167>