Bug 188143 - Shrink GraphicsLayer by making m_transform and m_childrenTransform be unique_ptrs
Summary: Shrink GraphicsLayer by making m_transform and m_childrenTransform be unique_...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-28 21:54 PDT by Simon Fraser (smfr)
Modified: 2018-07-30 09:43 PDT (History)
7 users (show)

See Also:


Attachments
Patch (11.80 KB, patch)
2018-07-28 21:56 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-sierra (2.36 MB, application/zip)
2018-07-28 23:05 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews107 for mac-sierra-wk2 (2.84 MB, application/zip)
2018-07-28 23:12 PDT, EWS Watchlist
no flags Details
Patch (11.81 KB, patch)
2018-07-29 08:46 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (12.38 KB, patch)
2018-07-29 09:57 PDT, Simon Fraser (smfr)
zalan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2018-07-28 21:54:30 PDT
Shrink GraphicsLayer by making m_transform and m_childrenTransform be unique_ptrs
Comment 1 Simon Fraser (smfr) 2018-07-28 21:56:26 PDT
Created attachment 346010 [details]
Patch
Comment 2 Darin Adler 2018-07-28 22:14:11 PDT
Comment on attachment 346010 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346010&action=review

> Source/WebCore/platform/graphics/GraphicsLayer.cpp:297
> +    NeverDestroyed<TransformationMatrix> identityTransform;

Need a "static" here!
Comment 3 EWS Watchlist 2018-07-28 23:05:19 PDT Comment hidden (obsolete)
Comment 4 EWS Watchlist 2018-07-28 23:05:21 PDT Comment hidden (obsolete)
Comment 5 EWS Watchlist 2018-07-28 23:12:35 PDT Comment hidden (obsolete)
Comment 6 EWS Watchlist 2018-07-28 23:12:37 PDT Comment hidden (obsolete)
Comment 7 Simon Fraser (smfr) 2018-07-29 08:46:05 PDT
Created attachment 346032 [details]
Patch
Comment 8 Simon Fraser (smfr) 2018-07-29 09:57:30 PDT
Created attachment 346033 [details]
Patch
Comment 9 Simon Fraser (smfr) 2018-07-30 09:38:02 PDT
https://trac.webkit.org/changeset/234368/webkit
Comment 10 Radar WebKit Bug Importer 2018-07-30 09:43:03 PDT
<rdar://problem/42735167>