| Summary: | [Cocoa] Update more WebCore Objective-C code to be ARC compatible | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||
| Component: | WebCore Misc. | Assignee: | Darin Adler <darin> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | andersca, dbates, ews-watchlist, mitz, sam, webkit-bug-importer, ysuzuki | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Darin Adler
2018-07-28 14:15:55 PDT
Created attachment 346001 [details]
Patch
Created attachment 346012 [details]
Patch
Comment on attachment 346012 [details] Patch Attachment 346012 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8689239 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html Created attachment 346022 [details]
Archive of layout-test-results from ews204 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Anyone got a theory about why that Windows test failed? Tempting to dismiss it as unrelated to this patch but I don’t know. (In reply to Darin Adler from comment #5) > Anyone got a theory about why that Windows test failed? Tempting to dismiss > it as unrelated to this patch but I don’t know. This http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html test is flaky these days. Even Intl in JS changes report this test is failing[1]. [1]: https://bugs.webkit.org/show_bug.cgi?id=167991 OK, so: passing tests, looking for a reviewer. Comment on attachment 346012 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346012&action=review > Source/WebCore/ChangeLog:59 > + (WebCore::DictionaryLookup::rangeForSelection): Return a typle rather Typo. You mean tuple I am pretty sure. Committed r234348: <https://trac.webkit.org/changeset/234348> |