Bug 188140

Summary: [Cocoa] Update more WebCore Objective-C code to be ARC compatible
Product: WebKit Reporter: Darin Adler <darin>
Component: WebCore Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, dbates, ews-watchlist, mitz, sam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
sam: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews204 for win-future none

Darin Adler
Reported 2018-07-28 14:15:55 PDT
[Cocoa] Update more WebCore Objective-C code to be ARC compatible
Attachments
Patch (95.69 KB, patch)
2018-07-28 15:10 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (97.19 KB, patch)
2018-07-28 22:21 PDT, Darin Adler 		sam: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews204 for win-future (12.95 MB, application/zip)
2018-07-29 02:03 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2018-07-28 15:10:07 PDT
Created attachment 346001 [details] Patch
Darin Adler
Comment 2 2018-07-28 22:21:03 PDT
Created attachment 346012 [details] Patch
EWS Watchlist
Comment 3 2018-07-29 02:03:12 PDT
Comment on attachment 346012 [details] Patch Attachment 346012 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8689239 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html
EWS Watchlist
Comment 4 2018-07-29 02:03:24 PDT
Created attachment 346022 [details] Archive of layout-test-results from ews204 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Darin Adler
Comment 5 2018-07-29 10:55:38 PDT
Anyone got a theory about why that Windows test failed? Tempting to dismiss it as unrelated to this patch but I don’t know.
Yusuke Suzuki
Comment 6 2018-07-29 11:18:00 PDT
(In reply to Darin Adler from comment #5) > Anyone got a theory about why that Windows test failed? Tempting to dismiss > it as unrelated to this patch but I don’t know. This http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html test is flaky these days. Even Intl in JS changes report this test is failing[1]. [1]: https://bugs.webkit.org/show_bug.cgi?id=167991
Darin Adler
Comment 7 2018-07-29 12:47:48 PDT
OK, so: passing tests, looking for a reviewer.
Sam Weinig
Comment 8 2018-07-29 13:45:42 PDT
Comment on attachment 346012 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346012&action=review > Source/WebCore/ChangeLog:59 > + (WebCore::DictionaryLookup::rangeForSelection): Return a typle rather Typo. You mean tuple I am pretty sure.
Darin Adler
Comment 9 2018-07-29 14:45:50 PDT
Committed r234348: <https://trac.webkit.org/changeset/234348>
Radar WebKit Bug Importer
Comment 10 2018-07-29 14:47:15 PDT
<rdar://problem/42713399>
Note You need to log in before you can comment on or make changes to this bug.