Bug 188137

Summary: Merge PlatformCookieJar functions into NetworkStorageSession
Product: WebKit Reporter: Rob Buis <rbuis>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, andersca, beidson, commit-queue, darin, dbates, ews-watchlist, fred.wang, mjs, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Rob Buis
Reported 2018-07-28 10:42:10 PDT
From PlatformCookieJar.h: // FIXME: These should probably be NetworkStorageSession member functions.
Attachments
Patch (110.05 KB, patch)
2018-07-28 13:19 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (109.98 KB, patch)
2018-07-28 23:13 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (126.77 KB, patch)
2018-07-29 02:08 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (126.77 KB, patch)
2018-07-29 04:32 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Patch (144.97 KB, patch)
2018-07-29 08:32 PDT, Rob Buis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2018-07-28 13:19:43 PDT
Created attachment 345998 [details] Patch
EWS Watchlist
Comment 2 2018-07-28 13:22:51 PDT
Attachment 345998 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:206: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Rob Buis
Comment 3 2018-07-28 23:13:04 PDT
Created attachment 346015 [details] Patch
EWS Watchlist
Comment 4 2018-07-28 23:15:57 PDT
Attachment 346015 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:206: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Rob Buis
Comment 5 2018-07-29 02:08:08 PDT
Created attachment 346023 [details] Patch
EWS Watchlist
Comment 6 2018-07-29 02:12:58 PDT
Attachment 346023 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:206: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:48: "WebKitSystemInterface/WebKitSystemInterface.h" already included at Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:38 [build/include] [4] Total errors found: 2 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Rob Buis
Comment 7 2018-07-29 04:32:08 PDT
Created attachment 346026 [details] Patch
EWS Watchlist
Comment 8 2018-07-29 04:33:58 PDT
Attachment 346026 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:206: More than one command on the same line [whitespace/newline] [4] ERROR: Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:48: "WebKitSystemInterface/WebKitSystemInterface.h" already included at Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:38 [build/include] [4] Total errors found: 2 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Rob Buis
Comment 9 2018-07-29 08:32:45 PDT
Created attachment 346030 [details] Patch
Frédéric Wang (:fredw)
Comment 10 2018-07-30 07:39:42 PDT
This LGTM but maybe someone familiar with the networking code should review it.
Alex Christensen
Comment 11 2018-07-30 11:49:14 PDT
Comment on attachment 346030 [details] Patch r=me, too. I wonder if https://bugs.webkit.org/show_bug.cgi?id=161106 would be easier after this.
Frédéric Wang (:fredw)
Comment 12 2018-07-30 12:04:04 PDT
(In reply to Alex Christensen from comment #11) > Comment on attachment 346030 [details] > Patch > > r=me, too. > I wonder if https://bugs.webkit.org/show_bug.cgi?id=161106 would be easier > after this. @Alex: Rob is in vacations so I guess we can land this patch now, especially if that helps you for bug 161106.
Rob Buis
Comment 13 2018-07-30 12:14:32 PDT
Hi guys, I am officially on vacations but only flying away next week, so feel free to CC me on bugs. Bug 161106 may be more something for Alex as I am still pretty new to cookie related code.
WebKit Commit Bot
Comment 14 2018-07-30 12:37:49 PDT
Comment on attachment 346030 [details] Patch Clearing flags on attachment: 346030 Committed r234376: <https://trac.webkit.org/changeset/234376>
WebKit Commit Bot
Comment 15 2018-07-30 12:37:50 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 16 2018-07-30 12:41:08 PDT
<rdar://problem/42742897>
Note You need to log in before you can comment on or make changes to this bug.