Bug 188134

Summary:

[ews-build] loadConfig should ensure that the triggers are valid

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, commit-queue, dean_johnson, ews-watchlist, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
Archive of layout-test-results from ews205 for win-future	none

Aakash Jain

Reported 2018-07-27 18:23:56 PDT

loadConfig should ensure that the triggers are valid, so as to prevent any errors in triggers. Two common cases of error in triggers are: 1) unused trigger in 'triggers' section of config.json 2) builder referencing non-existing trigger Unit-tests should fail when above error exist in config.json Also see: <rdar://problem/35892616> for related issue.

Attachments
Proposed patch (8.84 KB, patch) 2018-07-27 18:28 PDT, Aakash Jain	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews205 for win-future (13.03 MB, application/zip) 2018-07-28 00:36 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2018-07-27 18:28:11 PDT

Created attachment 345984 [details] Proposed patch

EWS Watchlist

Comment 2 2018-07-28 00:36:31 PDT Comment hidden (obsolete)

Comment on attachment 345984 [details] Proposed patch Attachment 345984 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8681037 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-video.html

EWS Watchlist

Comment 3 2018-07-28 00:36:43 PDT Comment hidden (obsolete)

Created attachment 345989 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

WebKit Commit Bot

Comment 4 2018-07-30 16:22:29 PDT

Comment on attachment 345984 [details] Proposed patch Clearing flags on attachment: 345984 Committed r234395: <https://trac.webkit.org/changeset/234395>

WebKit Commit Bot

Comment 5 2018-07-30 16:22:30 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 6 2018-07-30 16:24:10 PDT

<rdar://problem/42751331>

Note You need to log in before you can comment on or make changes to this bug.