Bug 188120

Summary:

Web Inspector: Dark Mode: disabled breakpoints banner is too light

Product:

WebKit

Reporter:

Matt Baker <mattbaker>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, inspector-bugzilla-changes, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Image] disabled breakpoints banner	none
Patch	none
[Image] With patch applied	none
Archive of layout-test-results from ews206 for win-future	none

Matt Baker

Reported 2018-07-27 12:57:59 PDT

Created attachment 345941 [details] [Image] disabled breakpoints banner Summary: Disabled breakpoints banner is too light. The banner is shown whenever breakpoints are disabled from the Debugger sidebar panel.

Attachments
[Image] disabled breakpoints banner (505.36 KB, image/png) 2018-07-27 12:57 PDT, Matt Baker	no flags	Details
Patch (1.55 KB, patch) 2018-07-31 17:47 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
[Image] With patch applied (58.86 KB, image/png) 2018-07-31 17:48 PDT, Nikita Vasilyev	no flags	Details
Archive of layout-test-results from ews206 for win-future (12.92 MB, application/zip) 2018-07-31 23:51 PDT, EWS Watchlist	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2018-07-27 12:58:22 PDT

<rdar://problem/42671348>

Nikita Vasilyev

Comment 2 2018-07-31 17:47:02 PDT

Created attachment 346237 [details] Patch Use the same styles as in Bug 187792 - Web Inspector: Dark Mode: poor contrast for Search Tab's "the page's content has changed" message.

Nikita Vasilyev

Comment 3 2018-07-31 17:48:00 PDT

Created attachment 346238 [details] [Image] With patch applied

EWS Watchlist

Comment 4 2018-07-31 23:51:18 PDT

Comment on attachment 346237 [details] Patch Attachment 346237 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8720731 New failing tests: imported/blink/transitions/unprefixed-transform.html

EWS Watchlist

Comment 5 2018-07-31 23:51:29 PDT

Created attachment 346263 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Matt Baker

Comment 6 2018-08-01 10:41:36 PDT

Comment on attachment 346237 [details] Patch r=me, looks great!

WebKit Commit Bot

Comment 7 2018-08-01 11:09:44 PDT

Comment on attachment 346237 [details] Patch Clearing flags on attachment: 346237 Committed r234464: <https://trac.webkit.org/changeset/234464>

WebKit Commit Bot

Comment 8 2018-08-01 11:09:46 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.