Bug 187792 - Web Inspector: Dark Mode: poor contrast for Search Tab's "the page's content has changed" message
Summary: Web Inspector: Dark Mode: poor contrast for Search Tab's "the page's content ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-18 16:23 PDT by Nikita Vasilyev
Modified: 2018-07-19 10:37 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.47 KB, patch)
2018-07-18 16:34 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Screenshot] With patch applied (43.51 KB, image/png)
2018-07-18 16:35 PDT, Nikita Vasilyev 		no flags Details
Archive of layout-test-results from ews200 for win-future (12.44 MB, application/zip)
2018-07-19 02:48 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2018-07-18 16:23:52 PDT 
Steps To Reproduce:
1. Browse to theonion.com
2. Search for something
3. Reload the page
=> shows “the page’s content has changed”

<rdar://problem/42339709>
Comment 1 Nikita Vasilyev 2018-07-18 16:34:34 PDT 
Created attachment 345302 [details]
Patch
Comment 2 Nikita Vasilyev 2018-07-18 16:35:55 PDT 
Created attachment 345304 [details]
[Screenshot] With patch applied
Comment 3 EWS Watchlist 2018-07-19 02:47:58 PDT 
Comment on attachment 345302 [details]
Patch

Attachment 345302 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8584675

New failing tests:
http/tests/preload/onload_event.html
Comment 4 EWS Watchlist 2018-07-19 02:48:10 PDT 
Created attachment 345341 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 5 BJ Burg 2018-07-19 10:09:29 PDT 
Comment on attachment 345302 [details]
Patch

rs=me
Comment 6 WebKit Commit Bot 2018-07-19 10:37:24 PDT 
Comment on attachment 345302 [details]
Patch

Clearing flags on attachment: 345302

Committed r233989: <https://trac.webkit.org/changeset/233989>
Comment 7 WebKit Commit Bot 2018-07-19 10:37:26 PDT 
All reviewed patches have been landed.  Closing bug.