Bug 188097

Summary: Fix thread-safety issues related to RealtimeMediaSource::audioSamplesAvailable()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: MediaAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 187284    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2018-07-27 10:45:17 PDT
Fix thread-safety issues related to RealtimeMediaSource::audioSamplesAvailable(). RealtimeMediaSource::audioSamplesAvailable() is called on a background thread but iterates over observers that may get destroyed concurrently on the main thread.
Attachments
Patch (18.83 KB, patch)
2018-07-27 13:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (18.90 KB, patch)
2018-07-27 13:53 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2018-07-27 11:05:10 PDT
<rdar://problem/42558823>
Chris Dumez
Comment 2 2018-07-27 13:02:03 PDT
Created attachment 345943 [details] Patch
Chris Dumez
Comment 3 2018-07-27 13:53:37 PDT
Created attachment 345950 [details] Patch
WebKit Commit Bot
Comment 4 2018-07-27 15:33:58 PDT
Comment on attachment 345950 [details] Patch Clearing flags on attachment: 345950 Committed r234334: <https://trac.webkit.org/changeset/234334>
WebKit Commit Bot
Comment 5 2018-07-27 15:34:00 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2018-07-27 15:34:34 PDT
<rdar://problem/42677538>
Note You need to log in before you can comment on or make changes to this bug.