Bug 188093

Summary: [WPE] Use WPE key symbols and new API instead of xkbcommon and the key mapper
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WPE WebKitAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, bugs-noreply, clopez, ews-watchlist, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://github.com/WebPlatformForEmbedded/WPEBackend/pull/23
https://github.com/Igalia/WPEBackend-fdo/pull/20
Bug Depends on:    
Bug Blocks: 188216    
Attachments:
Description Flags
WIP
none
Patch zan: review+

Description Carlos Garcia Campos 2018-07-27 01:41:26 PDT 
Use the new API.
Comment 1 Carlos Garcia Campos 2018-07-27 01:42:28 PDT 
Created attachment 345908 [details]
WIP
Comment 2 Zan Dobersek 2018-07-27 02:12:50 PDT 
Comment on attachment 345908 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=345908&action=review

> Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:306
> +    // FIXME: we don't have a way to get hardware key code in WPE.

This could be retrieved with a xkb_keymap object? If so, FIXME should note that.
Comment 3 Carlos Garcia Campos 2018-07-27 02:21:26 PDT 
(In reply to Zan Dobersek from comment #2)
> Comment on attachment 345908 [details]
> WIP
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=345908&action=review
> 
> > Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:306
> > +    // FIXME: we don't have a way to get hardware key code in WPE.
> 
> This could be retrieved with a xkb_keymap object? If so, FIXME should note
> that.

I don't know, I'll investigate.
Comment 4 Carlos Garcia Campos 2018-08-01 03:03:22 PDT 
(In reply to Carlos Garcia Campos from comment #3)
> (In reply to Zan Dobersek from comment #2)
> > Comment on attachment 345908 [details]
> > WIP
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=345908&action=review
> > 
> > > Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:306
> > > +    // FIXME: we don't have a way to get hardware key code in WPE.
> > 
> > This could be retrieved with a xkb_keymap object? If so, FIXME should note
> > that.
> 
> I don't know, I'll investigate.

It requires https://github.com/WebPlatformForEmbedded/WPEBackend/pull/24 I'll keep the FIXME anyway, since the patch to use the key mapper will introduce more changes.
Comment 5 Carlos Garcia Campos 2018-08-03 01:48:55 PDT 
Created attachment 346463 [details]
Patch
Comment 6 Zan Dobersek 2018-08-03 02:01:30 PDT 
Comment on attachment 346463 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346463&action=review

> Source/WebKit/ChangeLog:9
> +        
> +

Extra white space.

> Tools/ChangeLog:9
> +        
> +

Extra white space.

> Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:273
> +    // FIXME: we don't have a way to get hardware key code in WPE.

Is this now not retrievable from wpe_input_xkb_context_get_entries_for_key_code()? Or am I mixing things up?
Comment 7 Carlos Garcia Campos 2018-08-03 02:04:45 PDT 
(In reply to Zan Dobersek from comment #6)
> Comment on attachment 346463 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=346463&action=review
> 
> > Source/WebKit/ChangeLog:9
> > +        
> > +
> 
> Extra white space.
> 
> > Tools/ChangeLog:9
> > +        
> > +
> 
> Extra white space.
> 
> > Tools/WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:273
> > +    // FIXME: we don't have a way to get hardware key code in WPE.
> 
> Is this now not retrievable from
> wpe_input_xkb_context_get_entries_for_key_code()? Or am I mixing things up?

Yes, this is part of a follow up patch in bug #188216
Comment 8 Carlos Garcia Campos 2018-08-03 02:16:31 PDT 
Committed r234540: <https://trac.webkit.org/changeset/234540>