Bug 188082

Summary: Web Inspector: REGRESSION (r233824): execution highlight range missing/incorrect in pretty printed code
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[Webarchive] reduced test case
none
Patch none

Matt Baker
Reported 2018-07-26 15:27:21 PDT
Created attachment 345881 [details] [Webarchive] reduced test case Summary: Execution highlight range missing/incorrect in pretty printed code. Regressed in http://trac.webkit.org/changeset/233824. Steps to Reproduce: 1. Inspect the attached webarchive 2. View chained-property-stepping-min.js in Debugger tab 3. Enable pretty printing 4. Set breakpoint at line 13 5. Reload page => Paused in debugger Expected: => Expression-level execution highlight: |return 42| Actual: => Expression-level execution highlight missing (whole line is highlighted)
Attachments
[Webarchive] reduced test case (2.49 KB, application/x-webarchive)
2018-07-26 15:27 PDT, Matt Baker 		no flags
Details
Patch (3.34 KB, patch)
2018-10-12 17:56 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-07-26 15:27:50 PDT
<rdar://problem/42640580>
Matt Baker
Comment 2 2018-10-12 17:56:38 PDT
Created attachment 352246 [details] Patch
Joseph Pecoraro
Comment 3 2018-10-15 13:55:59 PDT
Comment on attachment 352246 [details] Patch r=me
WebKit Commit Bot
Comment 4 2018-10-15 14:21:25 PDT
Comment on attachment 352246 [details] Patch Clearing flags on attachment: 352246 Committed r237145: <https://trac.webkit.org/changeset/237145>
WebKit Commit Bot
Comment 5 2018-10-15 14:21:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.