Bug 188067 – Use the Page's appearance when converting pasteboard attributed strings

• Component: HTML Editing
• Status: RESOLVED FIXED

[Timothy Hatcher]

The color conversion of NSAttributedString rely on the appearance. We should use the page's appearance in this case.

[Radar WebKit Bug Importer]

<rdar://problem/42632246>

[Timothy Hatcher]

Created attachment 345856 [details]
Patch

[Megan Gardner]

Comment on attachment 345856 [details]
Patch

r=me, unofficial

[Wenson Hsieh]

Comment on attachment 345856 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345856&action=review

Is this testable in any way?

> Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:128
> +    auto* page = frame.page();

I was wondering if there's ever a case where page could be null, but it looks like we're okay here because createFragmentAndAddResources will bail if !frame.page().

[Timothy Hatcher]

(In reply to Wenson Hsieh from comment #4)
> Comment on attachment 345856 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=345856&action=review
> 
> Is this testable in any way?

Not currently. I am working on dark mode testing support in general and have many tests to add.

[WebKit Commit Bot]

Comment on attachment 345856 [details]
Patch

Clearing flags on attachment: 345856

Committed r234270: <https://trac.webkit.org/changeset/234270>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.