Bug 18806

Summary: Compilation breaks with arm-linux-g++ 3.4.6
Product: WebKit Reporter: Sriram Neelakandan <sriram.neelakandan>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alp
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Compilation fix
none
Compilation fix with arm 3.x compiler none

Sriram Neelakandan
Reported 2008-04-29 22:46:30 PDT
arm compilation breaks with gcc 3.4.6 compiler. Revision : r32652 arm-linux-g++ compiling file ../WebKit/gtk/webkit/webkitwebframe.cpp In file included from ../JavaScriptCore/kjs/lookup.h:28, from ../WebCore/bindings/js/kjs_binding.h:26, from ../WebCore/bindings/js/JSDOMWindowBase.h:25, from ./DerivedSources/JSDOMWindow.h:24, from ../WebKit/gtk/webkit/webkitwebframe.cpp:38: ../JavaScriptCore/kjs/JSGlobalObject.h: In constructor `KJS::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData()': ../JavaScriptCore/kjs/JSGlobalObject.h:82: error: no matching function for call to `KJS::PerThreadData::PerThreadData()' ../JavaScriptCore/kjs/ExecState.h:50: note: candidates are: KJS::PerThreadData::PerThreadData(const KJS::PerThreadData&) The default constructor in 3.x series takes a structure reference always. If we add an explicit default constructor, the compilation goes through fine
Attachments
Compilation fix (531 bytes, patch)
2008-04-29 22:56 PDT, Sriram Neelakandan 		no flags
DetailsFormatted DiffDiff
Compilation fix with arm 3.x compiler (889 bytes, patch)
2008-05-07 23:23 PDT, Sriram Neelakandan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sriram Neelakandan
Comment 1 2008-04-29 22:56:06 PDT
Created attachment 20898 [details] Compilation fix Default constructor has been declared explicitly to avoid the compilation breakage
Sriram Neelakandan
Comment 2 2008-05-07 23:23:37 PDT
Created attachment 21009 [details] Compilation fix with arm 3.x compiler added changelog & updated to latest revision
Alp Toker
Comment 3 2008-05-23 03:20:51 PDT
Comment on attachment 21009 [details] Compilation fix with arm 3.x compiler Issue fixed already.
Note You need to log in before you can comment on or make changes to this bug.