Summary: | Manually activate the selection assistant for Tap and a Half gestures | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Megan Gardner <megan_gardner> | ||||
Component: | New Bugs | Assignee: | Megan Gardner <megan_gardner> | ||||
Status: | RESOLVED WONTFIX | ||||||
Severity: | Normal | CC: | simon.fraser, thorton | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Megan Gardner
2018-07-25 21:01:50 PDT
Created attachment 345816 [details]
Patch
Comment on attachment 345816 [details]
Patch
Eww?
Also, test?
Comment on attachment 345816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345816&action=review > Source/WebKit/ChangeLog:11 > + is starting. This does not interfear with activation for other gestures, and it ensures that interfere > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2731 > + // <rdar://problem/42610532> Find a better way to make sure that the selection assistant is activated for tap and a half gestures Maybe don't include the radar title. Comment on attachment 345816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345816&action=review >> Source/WebKit/ChangeLog:11 >> + is starting. This does not interfear with activation for other gestures, and it ensures that > > interfere You don’t fear it? >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2731 >> + // <rdar://problem/42610532> Find a better way to make sure that the selection assistant is activated for tap and a half gestures > > Maybe don't include the radar title. Yeah, this can be one line even, with the radar in parens after fixme. Decided to go with a change in UIKit instead, as it was less hacky. |