Bug 187978

Summary: Turn assertion preventing removal of ActiveDOMObjects while we iterate over them into a RELEASE_ASSERT
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dbates, ddkilzer, eric.carlson, esprehn+autocc, ews-watchlist, ggaren, kangil.han, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews206 for win-future none

Description Chris Dumez 2018-07-24 16:33:51 PDT
Turn assertion preventing removal of ActiveDOMObjects while we iterate over them into a RELEASE_ASSERT. If code does this, this leads to hard to investigate crashes such as rdar://problem/42160890. With a release assertion, we would find the culprits right away.
The assertion guarding against addition of ActiveDOMObjects while we iterate is already a RELEASE_ASSERT.
Comment 1 Chris Dumez 2018-07-24 16:35:39 PDT
Created attachment 345725 [details]
Patch
Comment 2 EWS Watchlist 2018-07-24 20:43:39 PDT
Comment on attachment 345725 [details]
Patch

Attachment 345725 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8645595

New failing tests:
http/tests/security/canvas-remote-read-remote-video-localhost.html
Comment 3 EWS Watchlist 2018-07-24 20:43:51 PDT
Created attachment 345743 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 WebKit Commit Bot 2018-07-25 09:12:50 PDT
Comment on attachment 345725 [details]
Patch

Clearing flags on attachment: 345725

Committed r234197: <https://trac.webkit.org/changeset/234197>
Comment 5 WebKit Commit Bot 2018-07-25 09:12:51 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-07-25 09:14:18 PDT
<rdar://problem/42585290>