Bug 187976

Summary: Mask AVBackgroundView to the corner radius.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: commit-queue, eric.carlson, fred.wang, jonlee, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
jonlee: review+, jonlee: commit-queue-
Patch for landing. none

Jeremy Jones
Reported 2018-07-24 15:36:18 PDT
Mask AVBackgroundView to the corner radius.
Attachments
Patch (1.55 KB, patch)
2018-07-24 15:40 PDT, Jeremy Jones 		jonlee: review+
jonlee: commit-queue-
DetailsFormatted DiffDiff
Patch for landing. (1.65 KB, patch)
2018-07-25 14:42 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2018-07-24 15:37:17 PDT
rdar://problem/41810866
Jeremy Jones
Comment 2 2018-07-24 15:40:42 PDT
Created attachment 345721 [details] Patch
Sam Weinig
Comment 3 2018-07-24 17:38:09 PDT
Comment on attachment 345721 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345721&action=review > Source/WebKit/ChangeLog:12 > + This changes sets the appropriate mask to the layer so the corners look correct. > + > + * UIProcess/ios/fullscreen/WKFullscreenStackView.mm: > + (-[WKFullscreenStackView init]): How can this be tested?
Jon Lee
Comment 4 2018-07-24 20:46:42 PDT
Comment on attachment 345721 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345721&action=review > Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:63 > + [_backgroundView setClipsToBounds:YES]; Please add a FIXME for reverting this workaround.
Jeremy Jones
Comment 5 2018-07-25 14:38:31 PDT
(In reply to Jon Lee from comment #4) > Comment on attachment 345721 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345721&action=review > > > Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:63 > > + [_backgroundView setClipsToBounds:YES]; > > Please add a FIXME for reverting this workaround. Added bugzilla bug for the cleanup: https://bugs.webkit.org/show_bug.cgi?id=188022
Jeremy Jones
Comment 6 2018-07-25 14:42:51 PDT
Created attachment 345785 [details] Patch for landing.
Jeremy Jones
Comment 7 2018-07-25 14:43:36 PDT
(In reply to Sam Weinig from comment #3) > Comment on attachment 345721 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345721&action=review > > > Source/WebKit/ChangeLog:12 > > + This changes sets the appropriate mask to the layer so the corners look correct. > > + > > + * UIProcess/ios/fullscreen/WKFullscreenStackView.mm: > > + (-[WKFullscreenStackView init]): > > How can this be tested? We don't have a way to test this.
WebKit Commit Bot
Comment 8 2018-07-25 15:51:30 PDT
Comment on attachment 345785 [details] Patch for landing. Clearing flags on attachment: 345785 Committed r234216: <https://trac.webkit.org/changeset/234216>
Frédéric Wang (:fredw)
Comment 9 2018-09-20 13:30:14 PDT
Comment on attachment 345785 [details] Patch for landing. View in context: https://bugs.webkit.org/attachment.cgi?id=345785&action=review > Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:65 > + [_backgroundView.get().layer setContinuousCorners:YES]; For the record, this is causing build failure with XCode 10 (public SDK). I opened https://bugs.webkit.org/show_bug.cgi?id=189786
Note You need to log in before you can comment on or make changes to this bug.