Bug 187922

Summary: WebCore::primaryScreenDisplayID() always return 0
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebCore Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ggaren, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Per Arne Vollan
Reported 2018-07-23 13:52:48 PDT
This function should return a valid display ID.
Attachments
Patch (1.40 KB, patch)
2018-07-23 13:54 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2018-07-23 13:54:59 PDT
Created attachment 345604 [details] Patch
Per Arne Vollan
Comment 2 2018-07-23 13:56:00 PDT
<rdar://problem/42286933>
Geoffrey Garen
Comment 3 2018-07-23 14:19:46 PDT
Comment on attachment 345604 [details] Patch r=me You could probably test this in an automated way if you added a function or property in window.internals to override screenProperties().primaryDisplayID. That would at least test the fact that primaryScreenDisplayID() no longer unconditionally returns 0. (You just need the test harness to remember to
Geoffrey Garen
Comment 4 2018-07-23 14:20:01 PDT
...reset the value when it's done.
Per Arne Vollan
Comment 5 2018-07-23 14:46:56 PDT
(In reply to Geoffrey Garen from comment #4) > ...reset the value when it's done. Thanks for reviewing! I added https://bugs.webkit.org/show_bug.cgi?id=187922 to track adding a test.
WebKit Commit Bot
Comment 6 2018-07-23 15:16:38 PDT
Comment on attachment 345604 [details] Patch Clearing flags on attachment: 345604 Committed r234113: <https://trac.webkit.org/changeset/234113>
WebKit Commit Bot
Comment 7 2018-07-23 15:16:40 PDT
All reviewed patches have been landed. Closing bug.
Per Arne Vollan
Comment 8 2018-07-30 08:43:15 PDT
(In reply to Per Arne Vollan from comment #5) > (In reply to Geoffrey Garen from comment #4) > > ...reset the value when it's done. > > Thanks for reviewing! I added https://bugs.webkit.org/show_bug.cgi?id=187922 > to track adding a test. Sorry, that was not the correct bug. It should be https://bugs.webkit.org/show_bug.cgi?id=187925.
Note You need to log in before you can comment on or make changes to this bug.