Bug 187876

Summary: REGRESSION(r233925): Can't go into PiP twice
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: REOPENED    
Severity: Normal CC: commit-queue, eric.carlson, jeremyj-wk, jonlee, realdawei, ryanhaddad, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jer Noble
Reported 2018-07-20 17:08:07 PDT
REGRESSION(r233925): Can't go into PiP twice
Attachments
Patch (2.38 KB, patch)
2018-07-20 17:12 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2018-07-20 17:11:33 PDT
<rdar://problem/42444520>
Jer Noble
Comment 2 2018-07-20 17:12:25 PDT
Created attachment 345492 [details] Patch
Jeremy Jones
Comment 3 2018-07-20 17:24:08 PDT
Comment on attachment 345492 [details] Patch provisional r=me In this case the clientCount is unexpectedly not dropping to zero. There should be a bug filed about that too.
WebKit Commit Bot
Comment 4 2018-07-20 20:50:53 PDT
Comment on attachment 345492 [details] Patch Clearing flags on attachment: 345492 Committed r234081: <https://trac.webkit.org/changeset/234081>
WebKit Commit Bot
Comment 5 2018-07-20 20:50:55 PDT
All reviewed patches have been landed. Closing bug.
Dawei Fenton (:realdawei)
Comment 6 2018-08-06 16:23:16 PDT
After this revision The bots (High Sierra WK2 Debug) have been seeing flaky timeouts on TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction output from latest run: https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/builds/4382/steps/run-api-tests/logs/stdio
Ryan Haddad
Comment 7 2018-09-07 10:11:30 PDT
(In reply to Dawei Fenton (:realdawei) from comment #6) > After this revision The bots (High Sierra WK2 Debug) have been seeing flaky > timeouts on > TestWebKitAPI.VideoControlsManager. > VideoControlsManagerAudioElementFollowingUserInteraction This is still happening. Dawei, please file a bug.
Dawei Fenton (:realdawei)
Comment 8 2018-09-07 10:36:44 PDT
(In reply to Ryan Haddad from comment #7) > (In reply to Dawei Fenton (:realdawei) from comment #6) > > After this revision The bots (High Sierra WK2 Debug) have been seeing flaky > > timeouts on > > TestWebKitAPI.VideoControlsManager. > > VideoControlsManagerAudioElementFollowingUserInteraction > > This is still happening. Dawei, please file a bug. tracking it here: https://bugs.webkit.org/show_bug.cgi?id=187972
Note You need to log in before you can comment on or make changes to this bug.