Summary: | REGRESSION(r233925): Can't go into PiP twice | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||
Status: | REOPENED --- | ||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, jeremyj-wk, jonlee, realdawei, ryanhaddad, tsavell, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Jer Noble
2018-07-20 17:08:07 PDT
Created attachment 345492 [details]
Patch
Comment on attachment 345492 [details]
Patch
provisional r=me
In this case the clientCount is unexpectedly not dropping to zero. There should be a bug filed about that too.
Comment on attachment 345492 [details] Patch Clearing flags on attachment: 345492 Committed r234081: <https://trac.webkit.org/changeset/234081> All reviewed patches have been landed. Closing bug. After this revision The bots (High Sierra WK2 Debug) have been seeing flaky timeouts on TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction output from latest run: https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/builds/4382/steps/run-api-tests/logs/stdio (In reply to Dawei Fenton (:realdawei) from comment #6) > After this revision The bots (High Sierra WK2 Debug) have been seeing flaky > timeouts on > TestWebKitAPI.VideoControlsManager. > VideoControlsManagerAudioElementFollowingUserInteraction This is still happening. Dawei, please file a bug. (In reply to Ryan Haddad from comment #7) > (In reply to Dawei Fenton (:realdawei) from comment #6) > > After this revision The bots (High Sierra WK2 Debug) have been seeing flaky > > timeouts on > > TestWebKitAPI.VideoControlsManager. > > VideoControlsManagerAudioElementFollowingUserInteraction > > This is still happening. Dawei, please file a bug. tracking it here: https://bugs.webkit.org/show_bug.cgi?id=187972 |