Bug 187875

Summary: [LFC] Do not use virtual methods to construct floating/formatting states.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
koivisto: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews205 for win-future none

alan
Reported 2018-07-20 16:57:53 PDT
it just makes the code more complicated.
Attachments
Patch (13.78 KB, patch)
2018-07-20 18:42 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (13.79 KB, patch)
2018-07-20 18:48 PDT, alan 		koivisto: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews205 for win-future (12.93 MB, application/zip)
2018-07-20 22:37 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2018-07-20 18:42:11 PDT
Created attachment 345496 [details] Patch
alan
Comment 2 2018-07-20 18:48:09 PDT
Created attachment 345497 [details] Patch
EWS Watchlist
Comment 3 2018-07-20 22:37:03 PDT
Comment on attachment 345497 [details] Patch Attachment 345497 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8606179 New failing tests: http/tests/security/video-poster-cross-origin-crash2.html
EWS Watchlist
Comment 4 2018-07-20 22:37:14 PDT
Created attachment 345506 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
alan
Comment 5 2018-07-21 11:47:08 PDT
Committed r234084: <https://trac.webkit.org/changeset/234084>
Radar WebKit Bug Importer
Comment 6 2018-07-21 11:49:11 PDT
<rdar://problem/42467000>
Note You need to log in before you can comment on or make changes to this bug.