Bug 187873

Summary: REGRESSION (r233974): Cannot close pip'd video; pops back into PiP.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jeremyj-wk, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Jer Noble
Reported 2018-07-20 15:53:24 PDT
REGRESSION (r233974): Cannot close pip'd video; pops back into PiP.
Attachments
Patch (2.00 KB, patch)
2018-07-20 15:56 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2018-07-20 15:54:00 PDT
<rdar://problem/42442528>
Jer Noble
Comment 2 2018-07-20 15:56:32 PDT
Created attachment 345485 [details] Patch
Jon Lee
Comment 3 2018-07-20 16:31:03 PDT
Comment on attachment 345485 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345485&action=review > Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:-338 > - // FIXME 25096170: Should animate only if the page with the video is unobscured. For now, always close without animation. If this comment is going away, are we closing the associated also?
Jer Noble
Comment 4 2018-07-20 17:13:34 PDT
(In reply to Jon Lee from comment #3) > Comment on attachment 345485 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345485&action=review > > > Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm:-338 > > - // FIXME 25096170: Should animate only if the page with the video is unobscured. For now, always close without animation. > > If this comment is going away, are we closing the associated also? That comment was never right; this method only gets called when the "stop" button is clicked, so there is no animation.
WebKit Commit Bot
Comment 5 2018-07-20 17:42:27 PDT
Comment on attachment 345485 [details] Patch Clearing flags on attachment: 345485 Committed r234078: <https://trac.webkit.org/changeset/234078>
WebKit Commit Bot
Comment 6 2018-07-20 17:42:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.