Bug 187868

Summary: [WinCairo] Add implementation for setting cursors
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ews-watchlist, fujii.hironori, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-watchlist: commit-queue-
Archive of layout-test-results from ews106 for mac-sierra-wk2
none
Patch reupload
none
Patch none

Stephan Szabo
Reported 2018-07-20 11:16:33 PDT
[WinCairo] Add implementation for setting cursors
Attachments
Patch (1.67 KB, patch)
2018-07-20 11:20 PDT, Stephan Szabo 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-sierra-wk2 (3.20 MB, application/zip)
2018-07-20 12:41 PDT, EWS Watchlist 		no flags
Details
Patch reupload (1.67 KB, patch)
2018-07-20 13:14 PDT, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
Patch (2.40 KB, patch)
2018-07-23 13:48 PDT, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2018-07-20 11:20:14 PDT
Created attachment 345465 [details] Patch
EWS Watchlist
Comment 2 2018-07-20 12:41:46 PDT
Comment on attachment 345465 [details] Patch Attachment 345465 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8601823 New failing tests: accessibility/smart-invert-reference.html
EWS Watchlist
Comment 3 2018-07-20 12:41:48 PDT
Created attachment 345474 [details] Archive of layout-test-results from ews106 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Stephan Szabo
Comment 4 2018-07-20 13:14:07 PDT
Created attachment 345477 [details] Patch reupload
Fujii Hironori
Comment 5 2018-07-22 20:48:00 PDT
The original implementation handle WM_SETCURSOR. Do you need to do it? https://github.com/WebKit/webkit/blob/95edf431181ad3e174b3112afed085898d8d3f95/Source/WebKit2/UIProcess/win/WebView.cpp#L211
Stephan Szabo
Comment 6 2018-07-23 13:48:43 PDT
Created attachment 345603 [details] Patch The WM_SETCURSOR stuff was already in WebView, so tied back into that path from the page client implementation.
WebKit Commit Bot
Comment 7 2018-07-23 18:35:54 PDT
Comment on attachment 345603 [details] Patch Clearing flags on attachment: 345603 Committed r234129: <https://trac.webkit.org/changeset/234129>
WebKit Commit Bot
Comment 8 2018-07-23 18:35:56 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-07-23 18:36:22 PDT
<rdar://problem/42524657>
Note You need to log in before you can comment on or make changes to this bug.