| Summary: | [WinCairo] Add implementation for setting cursors | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Stephan Szabo <stephan.szabo> | ||||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | achristensen, commit-queue, ews-watchlist, Hironori.Fujii, rniwa, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Stephan Szabo
2018-07-20 11:16:33 PDT
Created attachment 345465 [details]
Patch
Comment on attachment 345465 [details] Patch Attachment 345465 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8601823 New failing tests: accessibility/smart-invert-reference.html Created attachment 345474 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 345477 [details]
Patch reupload
The original implementation handle WM_SETCURSOR. Do you need to do it? https://github.com/WebKit/webkit/blob/95edf431181ad3e174b3112afed085898d8d3f95/Source/WebKit2/UIProcess/win/WebView.cpp#L211 Created attachment 345603 [details]
Patch
The WM_SETCURSOR stuff was already in WebView, so tied back into that path from the page client implementation.
Comment on attachment 345603 [details] Patch Clearing flags on attachment: 345603 Committed r234129: <https://trac.webkit.org/changeset/234129> All reviewed patches have been landed. Closing bug. |