Bug 187858

Summary:	REGRESSION (234006) ERROR: Blocked access to external URL http://code.jquery.com/jquery-1.9.1.min.js
Product:	WebKit	Reporter:	Dawei Fenton (:realdawei) <realdawei>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	benton_richards, lforschler, realdawei, rniwa, ryanhaddad, tsavell, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=186414

Description Dawei Fenton (:realdawei) 2018-07-20 09:01:29 PDT

Performance tests are failing after revision: https://trac.webkit.org/changeset/234006/webkit

Sample error:
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Perf%29/builds/1264/steps/perf-test/logs/stdio

ERROR: Blocked access to external URL http://code.jquery.com/jquery-1.9.1.min.js

Comment 1 Ryosuke Niwa 2018-07-20 10:42:50 PDT

Oh, we have to add LaunchTime to Skipped file.

Comment 2 Dawei Fenton (:realdawei) 2018-07-20 11:27:05 PDT

(In reply to Ryosuke Niwa from comment #1)
> Oh, we have to add LaunchTime to Skipped file.

okay, should the revision be rolled out in in the interim? I would like to maintain green on the performance bots.

Comment 3 Ryan Haddad 2018-07-20 11:32:03 PDT

(In reply to David Fenton (:realdawei) from comment #2)
> (In reply to Ryosuke Niwa from comment #1)
> > Oh, we have to add LaunchTime to Skipped file.
> 
> okay, should the revision be rolled out in in the interim? I would like to
> maintain green on the performance bots.

I think we just need to add a line that says 'LaunchTime' to PerformanceTests/Skipped

Comment 4 Dawei Fenton (:realdawei) 2018-07-20 11:40:48 PDT

(In reply to Ryan Haddad from comment #3)
> (In reply to David Fenton (:realdawei) from comment #2)
> > (In reply to Ryosuke Niwa from comment #1)
> > > Oh, we have to add LaunchTime to Skipped file.
> > 
> > okay, should the revision be rolled out in in the interim? I would like to
> > maintain green on the performance bots.
> 
> I think we just need to add a line that says 'LaunchTime' to
> PerformanceTests/Skipped

Thanks, skipped in: https://trac.webkit.org/changeset/234059/webkit

Comment 5 Ryosuke Niwa 2018-07-20 12:19:00 PDT

Thanks. That's all that was needed.

Comment 6 Radar WebKit Bug Importer 2018-07-20 12:19:16 PDT

<rdar://problem/42440089>