Bug 187858 - REGRESSION (234006) ERROR: Blocked access to external URL http://code.jquery.com/jquery-1.9.1.min.js
Summary: REGRESSION (234006) ERROR: Blocked access to external URL http://code.jquery....
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-07-20 09:01 PDT by Dawei Fenton (:realdawei)
Modified: 2018-07-20 12:19 PDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dawei Fenton (:realdawei) 2018-07-20 09:01:29 PDT 
Performance tests are failing after revision: https://trac.webkit.org/changeset/234006/webkit

Sample error:
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Perf%29/builds/1264/steps/perf-test/logs/stdio

ERROR: Blocked access to external URL http://code.jquery.com/jquery-1.9.1.min.js
Comment 1 Ryosuke Niwa 2018-07-20 10:42:50 PDT 
Oh, we have to add LaunchTime to Skipped file.
Comment 2 Dawei Fenton (:realdawei) 2018-07-20 11:27:05 PDT 
(In reply to Ryosuke Niwa from comment #1)
> Oh, we have to add LaunchTime to Skipped file.

okay, should the revision be rolled out in in the interim? I would like to maintain green on the performance bots.
Comment 3 Ryan Haddad 2018-07-20 11:32:03 PDT 
(In reply to David Fenton (:realdawei) from comment #2)
> (In reply to Ryosuke Niwa from comment #1)
> > Oh, we have to add LaunchTime to Skipped file.
> 
> okay, should the revision be rolled out in in the interim? I would like to
> maintain green on the performance bots.

I think we just need to add a line that says 'LaunchTime' to PerformanceTests/Skipped
Comment 4 Dawei Fenton (:realdawei) 2018-07-20 11:40:48 PDT 
(In reply to Ryan Haddad from comment #3)
> (In reply to David Fenton (:realdawei) from comment #2)
> > (In reply to Ryosuke Niwa from comment #1)
> > > Oh, we have to add LaunchTime to Skipped file.
> > 
> > okay, should the revision be rolled out in in the interim? I would like to
> > maintain green on the performance bots.
> 
> I think we just need to add a line that says 'LaunchTime' to
> PerformanceTests/Skipped

Thanks, skipped in: https://trac.webkit.org/changeset/234059/webkit
Comment 5 Ryosuke Niwa 2018-07-20 12:19:00 PDT 
Thanks. That's all that was needed.
Comment 6 Radar WebKit Bug Importer 2018-07-20 12:19:16 PDT 
<rdar://problem/42440089>