Bug 187854

Summary: FrameView::paintContents should release log when the render tree is dirty.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2018-07-20 08:38:28 PDT
ssia
Attachments
Patch (1.75 KB, patch)
2018-07-20 09:43 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (1.77 KB, patch)
2018-07-20 10:09 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-07-20 09:37:01 PDT
<rdar://problem/42432371>
alan
Comment 2 2018-07-20 09:43:22 PDT
Created attachment 345451 [details] Patch
Simon Fraser (smfr)
Comment 3 2018-07-20 10:03:58 PDT
Comment on attachment 345451 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345451&action=review > Source/WebCore/page/FrameView.cpp:4146 > + RELEASE_LOG_IF_ALLOWED("painting: Render tree needs layout. Can't paint at this time -is mainframe(%d)", frame().isMainFrame()); Let's put "FrameView::paintContents" in the log message somewhere. Maybe "FrameView::paintContents() - not painting because render tree needs layout (is main frame %d)".
alan
Comment 4 2018-07-20 10:09:39 PDT
Created attachment 345455 [details] Patch
WebKit Commit Bot
Comment 5 2018-07-20 10:37:04 PDT
Comment on attachment 345455 [details] Patch Clearing flags on attachment: 345455 Committed r234053: <https://trac.webkit.org/changeset/234053>
WebKit Commit Bot
Comment 6 2018-07-20 10:37:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.