Bug 187854

Summary:

FrameView::paintContents should release log when the render tree is dirty.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2018-07-20 08:38:28 PDT

ssia

Comment 1 Radar WebKit Bug Importer 2018-07-20 09:37:01 PDT

<rdar://problem/42432371>

Comment 2 zalan 2018-07-20 09:43:22 PDT

Created attachment 345451 [details]
Patch

Comment 3 Simon Fraser (smfr) 2018-07-20 10:03:58 PDT

Comment on attachment 345451 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345451&action=review

> Source/WebCore/page/FrameView.cpp:4146
> +        RELEASE_LOG_IF_ALLOWED("painting: Render tree needs layout. Can't paint at this time -is mainframe(%d)", frame().isMainFrame());

Let's put "FrameView::paintContents" in the log message somewhere. Maybe "FrameView::paintContents() - not painting because render tree needs layout (is main frame %d)".

Comment 4 zalan 2018-07-20 10:09:39 PDT

Created attachment 345455 [details]
Patch

Comment 5 WebKit Commit Bot 2018-07-20 10:37:04 PDT

Comment on attachment 345455 [details]
Patch

Clearing flags on attachment: 345455

Committed r234053: <https://trac.webkit.org/changeset/234053>

Comment 6 WebKit Commit Bot 2018-07-20 10:37:05 PDT

All reviewed patches have been landed.  Closing bug.