Bug 187852

Summary: [JSC] A bit performance improvement for Object.assign by cleaning up code
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch saam: review+

Description Yusuke Suzuki 2018-07-20 03:06:38 PDT
[JSC] A bit performance improvement for Object.assign by cleaning up code
Comment 1 Yusuke Suzuki 2018-07-20 03:09:17 PDT
Created attachment 345438 [details]
Patch
Comment 2 Saam Barati 2018-07-20 10:57:48 PDT
Comment on attachment 345438 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345438&action=review

r=me

> Source/JavaScriptCore/ChangeLog:11
> +        2. canDoFastPath is not necessary. Restructuring the code to clean up things.

I agree this is a bit ugly, but the reason I wrote it that way so was we don't try to use the Structure* after the source could have potentially transitioned.

I would vote for just loading the structure twice instead of keeping a variable around that points to something that may no longer be source's structure. (LLVM should CSE the structure load anyways)
Comment 3 Yusuke Suzuki 2018-07-20 11:28:33 PDT
Committed r234058: <https://trac.webkit.org/changeset/234058>
Comment 4 Radar WebKit Bug Importer 2018-07-20 11:29:21 PDT
<rdar://problem/42437911>