Bug 187844

Summary: Remove completed animations from GraphicsLayer, thus avoiding excessive backing store allocation
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, dino, dstockwell, ews-watchlist, graouts, simon.fraser
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
dino: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews125 for ios-simulator-wk2 none

Simon Fraser (smfr)
Reported 2018-07-19 19:59:07 PDT
Remove completed animations from GraphicsLayer, thus avoiding excessive backing store allocation
Attachments
Patch (12.54 KB, patch)
2018-07-19 20:06 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (12.59 KB, patch)
2018-07-19 20:25 PDT, Simon Fraser (smfr) 		dino: review+
ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (2.25 MB, application/zip)
2018-07-19 22:18 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-07-19 20:06:01 PDT
Created attachment 345421 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-07-19 20:06:33 PDT
rdar://problem/40387294
Simon Fraser (smfr)
Comment 3 2018-07-19 20:25:16 PDT
Created attachment 345422 [details] Patch
EWS Watchlist
Comment 4 2018-07-19 22:18:26 PDT
Comment on attachment 345422 [details] Patch Attachment 345422 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8595479 New failing tests: compositing/backing/backing-store-attachment-fill-forwards-animation.html
EWS Watchlist
Comment 5 2018-07-19 22:18:27 PDT
Created attachment 345427 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Dean Jackson
Comment 6 2018-07-20 10:03:54 PDT
Comment on attachment 345422 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345422&action=review > Source/WebCore/page/animation/KeyframeAnimation.cpp:300 > +void KeyframeAnimation::endAnimation(bool fillingForwards) You say fillForwards in other places.
Simon Fraser (smfr)
Comment 7 2018-07-20 16:34:15 PDT
https://trac.webkit.org/changeset/234073/webkit
Note You need to log in before you can comment on or make changes to this bug.