Bug 187830

Summary: Reduce getters/setters in WebFramePolicyListenerProxy
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dino, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dino: review+

Description Alex Christensen 2018-07-19 17:07:56 PDT
Reduce getters/setters in WebFramePolicyListenerProxy
Comment 1 Alex Christensen 2018-07-19 17:11:14 PDT
Created attachment 345404 [details]
Patch
Comment 2 Dean Jackson 2018-07-23 16:00:30 PDT
Comment on attachment 345404 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345404&action=review

> Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h:54
> +enum class ShouldProcessSwapIfPossible { No, Yes };

Shouldn't this be ShouldProcessSwap { DoNotProcess, ProcessIfPossible } ?
Comment 3 Chris Dumez 2018-07-23 16:03:59 PDT
(In reply to Dean Jackson from comment #2)
> Comment on attachment 345404 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=345404&action=review
> 
> > Source/WebKit/UIProcess/WebFramePolicyListenerProxy.h:54
> > +enum class ShouldProcessSwapIfPossible { No, Yes };
> 
> Shouldn't this be ShouldProcessSwap { DoNotProcess, ProcessIfPossible } ?

DoNotProcess / ProcessIfPossible do not make sense. This is not about processing about about process swapping.
Comment 4 Alex Christensen 2018-07-24 10:27:28 PDT
http://trac.webkit.org/r234154
Comment 5 Radar WebKit Bug Importer 2018-07-24 10:28:24 PDT
<rdar://problem/42546369>