Bug 187786

Summary: [WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspector
Product: WebKit Reporter: Stephan Szabo <stephan.szabo>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, commit-queue, dbates, don.olmstead, fujii.hironori, mark.lam, mcatanzaro, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
fujii.hironori: review-
Support DEVELOPER_MODE for allowing inspection of web inspector none

Stephan Szabo
Reported 2018-07-18 15:15:26 PDT
[WinCairo] Add missing piece for inspecting web inspector
Attachments
Patch (2.32 KB, patch)
2018-07-18 15:19 PDT, Stephan Szabo 		fujii.hironori: review-
DetailsFormatted DiffDiff
Support DEVELOPER_MODE for allowing inspection of web inspector (2.23 KB, patch)
2018-07-19 11:51 PDT, Stephan Szabo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Stephan Szabo
Comment 1 2018-07-18 15:19:04 PDT
Created attachment 345292 [details] Patch
Stephan Szabo
Comment 2 2018-07-18 15:22:32 PDT
We had added the support for setting the flags behind ENABLE(DEVELOPER_MODE) ala GTK to make the inspector page have DeveloperExtrasEnabled, but not the bits in cmake/scripts to get the flag set from the build.
Fujii Hironori
Comment 4 2018-07-18 19:35:49 PDT
Comment on attachment 345292 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345292&action=review > Source/cmake/OptionsWin.cmake:96 > +SET_AND_EXPOSE_TO_BUILD(ENABLE_DEVELOPER_MODE ${DEVELOPER_MODE}) I think you should define it in OptionsWinCairo.cmake to keep AppleWin port untouched. > Tools/ChangeLog:3 > + [WinCairo] Add missing piece for inspecting web inspector What is the missing piece? I like more informative summary. > ChangeLog:8 > + * Source/cmake/OptionsWin.cmake: This change needs a more informative change log entry.
Stephan Szabo
Comment 5 2018-07-19 11:51:32 PDT
Created attachment 345370 [details] Support DEVELOPER_MODE for allowing inspection of web inspector
WebKit Commit Bot
Comment 6 2018-07-19 16:11:34 PDT
Comment on attachment 345370 [details] Support DEVELOPER_MODE for allowing inspection of web inspector Clearing flags on attachment: 345370 Committed r234010: <https://trac.webkit.org/changeset/234010>
WebKit Commit Bot
Comment 7 2018-07-19 16:11:36 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-07-19 16:14:01 PDT
<rdar://problem/42405082>
Note You need to log in before you can comment on or make changes to this bug.