Summary: | [WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspector | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Stephan Szabo <stephan.szabo> | ||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | clopez, commit-queue, dbates, don.olmstead, Hironori.Fujii, mark.lam, mcatanzaro, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Stephan Szabo
2018-07-18 15:15:26 PDT
Created attachment 345292 [details]
Patch
We had added the support for setting the flags behind ENABLE(DEVELOPER_MODE) ala GTK to make the inspector page have DeveloperExtrasEnabled, but not the bits in cmake/scripts to get the flag set from the build. Comment on attachment 345292 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345292&action=review > Source/cmake/OptionsWin.cmake:96 > +SET_AND_EXPOSE_TO_BUILD(ENABLE_DEVELOPER_MODE ${DEVELOPER_MODE}) I think you should define it in OptionsWinCairo.cmake to keep AppleWin port untouched. > Tools/ChangeLog:3 > + [WinCairo] Add missing piece for inspecting web inspector What is the missing piece? I like more informative summary. > ChangeLog:8 > + * Source/cmake/OptionsWin.cmake: This change needs a more informative change log entry. Created attachment 345370 [details]
Support DEVELOPER_MODE for allowing inspection of web inspector
Comment on attachment 345370 [details] Support DEVELOPER_MODE for allowing inspection of web inspector Clearing flags on attachment: 345370 Committed r234010: <https://trac.webkit.org/changeset/234010> All reviewed patches have been landed. Closing bug. |