Summary: | REGRESSION (r233897): CrashTracer: com.apple.WebKit.WebContent.Development at com.apple.WebKit: WKBooleanGetValue + 9 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | beidson, ggaren, rniwa, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Chris Dumez
2018-07-18 14:53:08 PDT
Created attachment 345290 [details]
Patch
Comment on attachment 345290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345290&action=review > Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:857 > + // The IPC failed. This happens when process swapping on navigation because the WebPageProxy unregisters itself When process *swaps* on navigation? (In reply to Ryosuke Niwa from comment #3) > Comment on attachment 345290 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345290&action=review > > > Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:857 > > + // The IPC failed. This happens when process swapping on navigation because the WebPageProxy unregisters itself > > When process *swaps* on navigation? "when process swapping on navigation" reads well to me, let's ask an American :) Brady? (In reply to Chris Dumez from comment #4) > (In reply to Ryosuke Niwa from comment #3) > > Comment on attachment 345290 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=345290&action=review > > > > > Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:857 > > > + // The IPC failed. This happens when process swapping on navigation because the WebPageProxy unregisters itself > > > > When process *swaps* on navigation? > > "when process swapping on navigation" reads well to me, let's ask an > American :) Brady? "process swapping" being a noun we've invented makes it read okay. I'd rewrite: "This happens when swapping processes on navigation..." (In reply to Brady Eidson from comment #5) > (In reply to Chris Dumez from comment #4) > > (In reply to Ryosuke Niwa from comment #3) > > > Comment on attachment 345290 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=345290&action=review > > > > > > > Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:857 > > > > + // The IPC failed. This happens when process swapping on navigation because the WebPageProxy unregisters itself > > > > > > When process *swaps* on navigation? > > > > "when process swapping on navigation" reads well to me, let's ask an > > American :) Brady? > > "process swapping" being a noun we've invented makes it read okay. Both a noun and a verb, but regardless it requires you to be familiar with it. My proposed rewrite doesn't: > > I'd rewrite: "This happens when swapping processes on navigation..." Committed r233941: <https://trac.webkit.org/changeset/233941> |