Bug 187751

Summary: [CoordGraphics] Start tracking Nicosia layers in CoordinatedGraphicsState
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, magomez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 187385    
Attachments:
Description Flags
Patch
none
Patch for landing none

Zan Dobersek
Reported 2018-07-18 00:52:12 PDT
[CoordGraphics] Start tracking Nicosia layers in CoordinatedGraphicsState
Attachments
Patch (9.68 KB, patch)
2018-07-18 01:05 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch for landing (9.69 KB, patch)
2018-07-18 03:17 PDT, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2018-07-18 01:05:25 PDT
Created attachment 345232 [details] Patch
Carlos Garcia Campos
Comment 2 2018-07-18 01:34:21 PDT
Comment on attachment 345232 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345232&action=review > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:1116 > + return m_nicosia.layer; Can this RefPtr contain nullptr? If not, we could probably return a const Nicosia::CompositionLayer& instead. > Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:435 > + // TODO: Start using the Nicosia layer state for updates. Use FIXME instead of TODO
Zan Dobersek
Comment 3 2018-07-18 03:13:55 PDT
Comment on attachment 345232 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345232&action=review >> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:1116 >> + return m_nicosia.layer; > > Can this RefPtr contain nullptr? If not, we could probably return a const Nicosia::CompositionLayer& instead. It can't be null. But every time this is called, it wants a RefPtr that can then be copied. Changing this into a const reference means bending over backwards to get it back into a RefPtr<> at every callsite.
Zan Dobersek
Comment 4 2018-07-18 03:17:23 PDT
Created attachment 345234 [details] Patch for landing
Zan Dobersek
Comment 5 2018-07-18 03:20:23 PDT
Comment on attachment 345234 [details] Patch for landing Clearing flags on attachment: 345234 Committed r233909: <https://trac.webkit.org/changeset/233909>
Zan Dobersek
Comment 6 2018-07-18 03:20:26 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2018-07-18 03:21:25 PDT
<rdar://problem/42328098>
Note You need to log in before you can comment on or make changes to this bug.