Summary: | [CoordGraphics] Start tracking Nicosia layers in CoordinatedGraphicsState | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cgarcia, magomez, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 187385 | ||||||||
Attachments: |
|
Description
Zan Dobersek
2018-07-18 00:52:12 PDT
Created attachment 345232 [details]
Patch
Comment on attachment 345232 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345232&action=review > Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:1116 > + return m_nicosia.layer; Can this RefPtr contain nullptr? If not, we could probably return a const Nicosia::CompositionLayer& instead. > Source/WebKit/Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:435 > + // TODO: Start using the Nicosia layer state for updates. Use FIXME instead of TODO Comment on attachment 345232 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345232&action=review >> Source/WebCore/platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:1116 >> + return m_nicosia.layer; > > Can this RefPtr contain nullptr? If not, we could probably return a const Nicosia::CompositionLayer& instead. It can't be null. But every time this is called, it wants a RefPtr that can then be copied. Changing this into a const reference means bending over backwards to get it back into a RefPtr<> at every callsite. Created attachment 345234 [details]
Patch for landing
Comment on attachment 345234 [details] Patch for landing Clearing flags on attachment: 345234 Committed r233909: <https://trac.webkit.org/changeset/233909> All reviewed patches have been landed. Closing bug. |