Bug 187717

Summary: Add color filter for transforming colors in Dark Mode
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, enrica, ews-watchlist, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review+

Simon Fraser (smfr)
Reported 2018-07-16 16:55:21 PDT
Add color filter for transforming colors in Dark Mode
Attachments
Patch (49.32 KB, patch)
2018-07-16 16:57 PDT, Simon Fraser (smfr) 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2018-07-16 16:57:30 PDT
Created attachment 345130 [details] Patch
Simon Fraser (smfr)
Comment 2 2018-07-16 16:57:49 PDT
rdar://problem/41146650
EWS Watchlist
Comment 3 2018-07-16 17:01:00 PDT
Attachment 345130 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/filters/FilterOperation.h:59: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/platform/graphics/filters/FilterOperation.h:277: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/platform/graphics/filters/FilterOperation.h:282: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/platform/graphics/filters/FilterOperation.h:293: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4] ERROR: Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:407: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 5 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 4 2018-07-16 19:04:19 PDT
Comment on attachment 345130 [details] Patch Dean reviewed this
Simon Fraser (smfr)
Comment 5 2018-07-16 19:04:42 PDT
https://trac.webkit.org/changeset/233877/webkit
Note You need to log in before you can comment on or make changes to this bug.