Summary: | Add color filter for transforming colors in Dark Mode | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dino, enrica, ews-watchlist, simon.fraser, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2018-07-16 16:55:21 PDT
Created attachment 345130 [details]
Patch
Attachment 345130 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/graphics/filters/FilterOperation.h:59: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/filters/FilterOperation.h:277: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
ERROR: Source/WebCore/platform/graphics/filters/FilterOperation.h:282: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
ERROR: Source/WebCore/platform/graphics/filters/FilterOperation.h:293: Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line. [build/webcore_export] [4]
ERROR: Source/WebCore/platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:407: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
Total errors found: 5 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 345130 [details]
Patch
Dean reviewed this
|