Bug 187713

Summary: Release assert in ~TimerBase is getting hit in WK1 apps which uses JSC API directly
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, ddkilzer, mark.lam, simon.fraser
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the crash
none
Fixed non-iOS builds simon.fraser: review+

Description Ryosuke Niwa 2018-07-16 15:29:19 PDT 
Apparently, JSC API doesn't grab the web thread lock, as a result, some apps are hitting the release assertion in ~TimerBase.

<rdar://problem/41759548>
Comment 1 Ryosuke Niwa 2018-07-16 15:31:03 PDT 
Created attachment 345124 [details]
Fixes the crash
Comment 2 Mark Lam 2018-07-16 15:45:23 PDT 
The GTK and wpe build failure looks legit.
Comment 3 Ryosuke Niwa 2018-07-16 16:10:09 PDT 
Created attachment 345128 [details]
Fixed non-iOS builds
Comment 4 Simon Fraser (smfr) 2018-07-16 19:09:02 PDT 
Comment on attachment 345128 [details]
Fixed non-iOS builds

View in context: https://bugs.webkit.org/attachment.cgi?id=345128&action=review

> Source/WebCore/ChangeLog:8
> +        Turn this into a debug assertion in WebKit1.

This needs more explanation that mentions the JSC lack of WebThreadLock etc, and reference a radar.
Comment 5 Ryosuke Niwa 2018-07-16 19:50:13 PDT 
Committed r233879: <https://trac.webkit.org/changeset/233879>