Bug 187704

Summary: jsc shell's noFTL utility test function should be more robust.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. msaboff: review+

Mark Lam
Reported 2018-07-16 11:04:53 PDT
<rdar://problem/42231988>
Attachments
proposed patch. (1.54 KB, patch)
2018-07-16 11:13 PDT, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2018-07-16 11:13:20 PDT
Created attachment 345102 [details] proposed patch.
Michael Saboff
Comment 2 2018-07-16 11:34:25 PDT
Comment on attachment 345102 [details] proposed patch. r=me
Keith Miller
Comment 3 2018-07-16 11:34:41 PDT
Comment on attachment 345102 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=345102&action=review r=me. > Source/JavaScriptCore/jsc.cpp:1443 > + if (exec->argumentCount() >= 1) { Nit: you can just do if (exec->argumentCount()) here.
Mark Lam
Comment 4 2018-07-16 11:38:52 PDT
Comment on attachment 345102 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=345102&action=review >> Source/JavaScriptCore/jsc.cpp:1443 >> + if (exec->argumentCount() >= 1) { > > Nit: you can just do if (exec->argumentCount()) here. Will fix before landing.
Mark Lam
Comment 5 2018-07-16 11:43:02 PDT
Thanks for the review. Landed in r233854: <http://trac.webkit.org/r233854>.
Note You need to log in before you can comment on or make changes to this bug.