Bug 187675

Summary: CustomConfigurationTestGroupForm should dispatch different arguments based on whether analysis task is created.
Product: WebKit Reporter: dewei_zhu
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dewei_zhu, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

dewei_zhu
Reported 2018-07-13 18:40:08 PDT
CustomConfigurationTestGroupForm should dispatch different arguments based on whether analysis task is created.
Attachments
Patch (2.33 KB, patch)
2018-07-13 18:46 PDT, dewei_zhu 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
dewei_zhu
Comment 1 2018-07-13 18:46:06 PDT
Created attachment 345014 [details] Patch
Ryosuke Niwa
Comment 2 2018-07-16 20:00:38 PDT
Comment on attachment 345014 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345014&action=review > Websites/perf.webkit.org/public/v3/components/custom-configuration-test-group-form.js:41 > + if (!this._hasTask) We should assert that !!this._hasTask == !taskName
dewei_zhu
Comment 3 2018-07-16 22:18:21 PDT
Landed in r233884.
Note You need to log in before you can comment on or make changes to this bug.