Bug 187665

Summary:

Add _drawsBackground to WKWebViewConfiguration

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

WebKit API

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, commit-queue, ews-watchlist, rniwa, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews106 for mac-sierra-wk2	none

Description Timothy Hatcher 2018-07-13 14:56:25 PDT

WebViews that need to be transparent often flash white before _drawsBackground can be set to NO on the WKWebView.

Add _drawsBackground to WKWebViewConfiguration so it can be passed in at instantiation.

Comment 1 Radar WebKit Bug Importer 2018-07-13 14:57:03 PDT

<rdar://problem/42182268>

Comment 2 Tim Horton 2018-07-13 15:19:34 PDT

Why do they flash? It’s in WebPageCreationParameters, so as long as it’s set *before* clients load (and thus launch a process) (and also as long as they do it in the same runloop as they create the view), shouldn’t that be sufficient?

Comment 3 Timothy Hatcher 2018-07-13 15:22:29 PDT Comment hidden (obsolete)

Created attachment 344991 [details]
Patch

Comment 4 Anders Carlsson 2018-07-13 15:23:40 PDT Comment hidden (obsolete)

Comment on attachment 344991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344991&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:312
> +    self._drawsBackground = [coder decodeBoolForKey:@"drawsBackground"];

Shouldn't this default to YES if the key is missing?

Comment 5 Timothy Hatcher 2018-07-13 15:49:16 PDT

Created attachment 344996 [details]
Patch

Comment 6 Tim Horton 2018-07-13 16:06:46 PDT

Comment on attachment 344996 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344996&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:45
> +TEST(WebKit, ConfigurationDrawsBackground)

Tests! Crazy.

Comment 7 EWS Watchlist 2018-07-13 16:42:36 PDT Comment hidden (obsolete)

Comment on attachment 344996 [details]
Patch

Attachment 344996 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8530702

New failing tests:
accessibility/smart-invert-reference.html

Comment 8 EWS Watchlist 2018-07-13 16:42:38 PDT Comment hidden (obsolete)

Created attachment 345002 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6

Comment 9 WebKit Commit Bot 2018-07-13 17:03:55 PDT

Comment on attachment 344996 [details]
Patch

Clearing flags on attachment: 344996

Committed r233828: <https://trac.webkit.org/changeset/233828>

Comment 10 WebKit Commit Bot 2018-07-13 17:03:57 PDT

All reviewed patches have been landed.  Closing bug.