Bug 187643

Summary: [GStreamer] Implement bitrate modulation support in GStreamer based libwebrtc Encoders
Product: WebKit Reporter: Thibault Saunier <tsaunier>
Component: New BugsAssignee: Thibault Saunier <tsaunier>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, commit-queue, pnormand, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 186932    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Thibault Saunier
Reported 2018-07-13 08:17:54 PDT
[GStreamer] Implement bitrate modulation support in GStreamer based libwebrtc Encoders
Attachments
Patch (8.93 KB, patch)
2018-07-13 08:35 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Patch (8.96 KB, patch)
2018-07-13 15:47 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Patch (8.96 KB, patch)
2018-07-23 07:58 PDT, Thibault Saunier 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Thibault Saunier
Comment 1 2018-07-13 08:35:04 PDT
Created attachment 344946 [details] Patch
Thibault Saunier
Comment 2 2018-07-13 15:47:27 PDT
Created attachment 344995 [details] Patch Fix small bitrate conversion issue
Philippe Normand
Comment 3 2018-07-19 02:12:40 PDT
Comment on attachment 344995 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344995&action=review LGTM! > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:389 > + if (caps && m_profile.get() && gst_caps_is_equal (m_restrictionCaps.get(), caps)) No space before (
Thibault Saunier
Comment 4 2018-07-23 07:57:24 PDT
(In reply to Philippe Normand from comment #3) > Comment on attachment 344995 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=344995&action=review > > LGTM! > > > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:389 > > + if (caps && m_profile.get() && gst_caps_is_equal (m_restrictionCaps.get(), caps)) > > No space before ( Fixed.
Thibault Saunier
Comment 5 2018-07-23 07:58:41 PDT
Created attachment 345572 [details] Patch
Philippe Normand
Comment 6 2018-07-24 01:28:13 PDT
Comment on attachment 345572 [details] Patch Let's see if this lands :)
WebKit Commit Bot
Comment 7 2018-07-24 02:08:18 PDT
Comment on attachment 345572 [details] Patch Clearing flags on attachment: 345572 Committed r234141: <https://trac.webkit.org/changeset/234141>
WebKit Commit Bot
Comment 8 2018-07-24 02:08:19 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2018-07-24 02:09:18 PDT
<rdar://problem/42533922>
Note You need to log in before you can comment on or make changes to this bug.