Summary: | [GStreamer] Implement bitrate modulation support in GStreamer based libwebrtc Encoders | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Thibault Saunier <tsaunier> | ||||||||
Component: | New Bugs | Assignee: | Thibault Saunier <tsaunier> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | alex, commit-queue, pnormand, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 186932 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Thibault Saunier
2018-07-13 08:17:54 PDT
Created attachment 344946 [details]
Patch
Created attachment 344995 [details]
Patch
Fix small bitrate conversion issue
Comment on attachment 344995 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344995&action=review LGTM! > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:389 > + if (caps && m_profile.get() && gst_caps_is_equal (m_restrictionCaps.get(), caps)) No space before ( (In reply to Philippe Normand from comment #3) > Comment on attachment 344995 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=344995&action=review > > LGTM! > > > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:389 > > + if (caps && m_profile.get() && gst_caps_is_equal (m_restrictionCaps.get(), caps)) > > No space before ( Fixed. Created attachment 345572 [details]
Patch
Comment on attachment 345572 [details]
Patch
Let's see if this lands :)
Comment on attachment 345572 [details] Patch Clearing flags on attachment: 345572 Committed r234141: <https://trac.webkit.org/changeset/234141> All reviewed patches have been landed. Closing bug. |