Bug 187623

Summary: PiP from Element Fullscreen should match AVKit's behavior
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, jeremyj-wk, jonlee, rniwa, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews106 for mac-sierra-wk2
none
Patch
none
Patch
none
Patch
none
Patch none

Description Jer Noble 2018-07-12 15:48:27 PDT
PiP from Element Fullscreen should match AVKit's behavior
Comment 1 Jer Noble 2018-07-13 11:00:58 PDT
<rdar://problem/41212379>
Comment 2 Jer Noble 2018-07-13 11:01:50 PDT
Created attachment 344957 [details]
Patch
Comment 3 EWS Watchlist 2018-07-13 12:15:28 PDT
Comment on attachment 344957 [details]
Patch

Attachment 344957 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8527032

New failing tests:
media/fullscreen-video-going-into-pip.html
media/video-contained-in-fullscreen-element-going-into-pip.html
Comment 4 EWS Watchlist 2018-07-13 12:15:30 PDT
Created attachment 344964 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 Jer Noble 2018-07-16 12:27:15 PDT
Created attachment 345110 [details]
Patch
Comment 6 Jer Noble 2018-07-16 14:12:13 PDT
Created attachment 345118 [details]
Patch
Comment 7 Jer Noble 2018-07-16 15:07:09 PDT
Created attachment 345122 [details]
Patch
Comment 8 Jer Noble 2018-07-17 19:05:56 PDT
Created attachment 345217 [details]
Patch
Comment 9 WebKit Commit Bot 2018-07-18 12:50:12 PDT
Comment on attachment 345217 [details]
Patch

Clearing flags on attachment: 345217

Committed r233926: <https://trac.webkit.org/changeset/233926>
Comment 10 WebKit Commit Bot 2018-07-18 12:50:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Jer Noble 2018-07-18 15:30:49 PDT
Committed build fix in r233930: <http://trac.webkit.org/r233930>.
Committed API test fix in r233936: <http://trac.webkit.org/r233936>.
Comment 12 Truitt Savell 2018-07-19 09:58:06 PDT
The revision r233926: <https://trac.webkit.org/changeset/233926> caused this test to constantly Timeout: 

media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html

Test History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fmedia-controller%2Fmedia-controller-inline-to-fullscreen-to-pip-to-inline.html