Summary: | PiP from Element Fullscreen should match AVKit's behavior | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | commit-queue, ews-watchlist, jeremyj-wk, jonlee, rniwa, tsavell, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Jer Noble
2018-07-12 15:48:27 PDT
Created attachment 344957 [details]
Patch
Comment on attachment 344957 [details] Patch Attachment 344957 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/8527032 New failing tests: media/fullscreen-video-going-into-pip.html media/video-contained-in-fullscreen-element-going-into-pip.html Created attachment 344964 [details]
Archive of layout-test-results from ews106 for mac-sierra-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Created attachment 345110 [details]
Patch
Created attachment 345118 [details]
Patch
Created attachment 345122 [details]
Patch
Created attachment 345217 [details]
Patch
Comment on attachment 345217 [details] Patch Clearing flags on attachment: 345217 Committed r233926: <https://trac.webkit.org/changeset/233926> All reviewed patches have been landed. Closing bug. Committed build fix in r233930: <http://trac.webkit.org/r233930>. Committed API test fix in r233936: <http://trac.webkit.org/r233936>. The revision r233926: <https://trac.webkit.org/changeset/233926> caused this test to constantly Timeout: media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html Test History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fmedia-controller%2Fmedia-controller-inline-to-fullscreen-to-pip-to-inline.html |