Bug 187612

Summary: Web Inspector: Type token positioning should use line/column locations from Esprima instead of offsets
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, inspector-bugzilla-changes, joepeck, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 186453, 187532    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews205 for win-future none

Matt Baker
Reported 2018-07-12 12:00:54 PDT
Summary: Type token positioning should use line/column locations from Esprima instead of offsets. TypeTokenAnnotator calculates positions for type tokens using offsets from Esprima AST nodes. Once CodeMirror returns to auto-detecting line endings (see https://webkit.org/b/186453), these offsets won't correspond to CodeMirror's offsets for the same tokens.
Attachments
Patch (13.55 KB, patch)
2018-07-12 12:23 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews205 for win-future (12.97 MB, application/zip)
2018-07-12 15:10 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-07-12 12:10:16 PDT
<rdar://problem/42131910>
Matt Baker
Comment 2 2018-07-12 12:23:17 PDT
Created attachment 344872 [details] Patch
EWS Watchlist
Comment 3 2018-07-12 15:10:08 PDT
Comment on attachment 344872 [details] Patch Attachment 344872 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8519412 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html
EWS Watchlist
Comment 4 2018-07-12 15:10:20 PDT
Created attachment 344887 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Joseph Pecoraro
Comment 5 2018-07-12 16:45:08 PDT
Comment on attachment 344872 [details] Patch r=me
WebKit Commit Bot
Comment 6 2018-07-12 19:06:55 PDT
Comment on attachment 344872 [details] Patch Clearing flags on attachment: 344872 Committed r233792: <https://trac.webkit.org/changeset/233792>
WebKit Commit Bot
Comment 7 2018-07-12 19:06:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.