Bug 187563

Summary: Add compile guard for enabling NSRunLoop in the WebContent process.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Per Arne Vollan
Reported 2018-07-11 14:14:54 PDT
Also, we should replace __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 with ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) where appropriate.
Attachments
Patch (12.93 KB, patch)
2018-07-11 14:31 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (13.08 KB, patch)
2018-07-12 07:37 PDT, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2018-07-11 14:31:49 PDT
Created attachment 344782 [details] Patch
Chris Dumez
Comment 2 2018-07-11 14:38:37 PDT
Comment on attachment 344782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344782&action=review > Source/WTF/wtf/FeatureDefines.h:245 > +#define ENABLE_WEBPROCESS_NSRUNLOOP __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 Does't WEBPROCESS_WINDOWSERVER_BLOCKING need to rely on ENABLE_WEBPROCESS_NSRUNLOOP being 1?
Per Arne Vollan
Comment 3 2018-07-12 07:37:31 PDT
Created attachment 344843 [details] Patch
Per Arne Vollan
Comment 4 2018-07-12 07:38:25 PDT
(In reply to Chris Dumez from comment #2) > Comment on attachment 344782 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=344782&action=review > > > Source/WTF/wtf/FeatureDefines.h:245 > > +#define ENABLE_WEBPROCESS_NSRUNLOOP __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 > > Does't WEBPROCESS_WINDOWSERVER_BLOCKING need to rely on > ENABLE_WEBPROCESS_NSRUNLOOP being 1? Thanks for reviewing! I have updated the patch.
Chris Dumez
Comment 5 2018-07-12 08:30:32 PDT
Comment on attachment 344843 [details] Patch r=me
WebKit Commit Bot
Comment 6 2018-07-12 09:02:18 PDT
Comment on attachment 344843 [details] Patch Clearing flags on attachment: 344843 Committed r233769: <https://trac.webkit.org/changeset/233769>
WebKit Commit Bot
Comment 7 2018-07-12 09:02:20 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2018-07-12 09:03:26 PDT
<rdar://problem/42123360>
Note You need to log in before you can comment on or make changes to this bug.