Summary: | Add compile guard for enabling NSRunLoop in the WebContent process. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||
Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | benjamin, bfulgham, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Per Arne Vollan
2018-07-11 14:14:54 PDT
Created attachment 344782 [details]
Patch
Comment on attachment 344782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344782&action=review > Source/WTF/wtf/FeatureDefines.h:245 > +#define ENABLE_WEBPROCESS_NSRUNLOOP __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 Does't WEBPROCESS_WINDOWSERVER_BLOCKING need to rely on ENABLE_WEBPROCESS_NSRUNLOOP being 1? Created attachment 344843 [details]
Patch
(In reply to Chris Dumez from comment #2) > Comment on attachment 344782 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=344782&action=review > > > Source/WTF/wtf/FeatureDefines.h:245 > > +#define ENABLE_WEBPROCESS_NSRUNLOOP __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 > > Does't WEBPROCESS_WINDOWSERVER_BLOCKING need to rely on > ENABLE_WEBPROCESS_NSRUNLOOP being 1? Thanks for reviewing! I have updated the patch. Comment on attachment 344843 [details]
Patch
r=me
Comment on attachment 344843 [details] Patch Clearing flags on attachment: 344843 Committed r233769: <https://trac.webkit.org/changeset/233769> All reviewed patches have been landed. Closing bug. |