Bug 187563

Summary: Add compile guard for enabling NSRunLoop in the WebContent process.
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Per Arne Vollan 2018-07-11 14:14:54 PDT
Also, we should replace __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400 with ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) where appropriate.
Comment 1 Per Arne Vollan 2018-07-11 14:31:49 PDT
Created attachment 344782 [details]
Patch
Comment 2 Chris Dumez 2018-07-11 14:38:37 PDT
Comment on attachment 344782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344782&action=review

> Source/WTF/wtf/FeatureDefines.h:245
> +#define ENABLE_WEBPROCESS_NSRUNLOOP __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400

Does't WEBPROCESS_WINDOWSERVER_BLOCKING need to rely on ENABLE_WEBPROCESS_NSRUNLOOP being 1?
Comment 3 Per Arne Vollan 2018-07-12 07:37:31 PDT
Created attachment 344843 [details]
Patch
Comment 4 Per Arne Vollan 2018-07-12 07:38:25 PDT
(In reply to Chris Dumez from comment #2)
> Comment on attachment 344782 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344782&action=review
> 
> > Source/WTF/wtf/FeatureDefines.h:245
> > +#define ENABLE_WEBPROCESS_NSRUNLOOP __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
> 
> Does't WEBPROCESS_WINDOWSERVER_BLOCKING need to rely on
> ENABLE_WEBPROCESS_NSRUNLOOP being 1?

Thanks for reviewing! I have updated the patch.
Comment 5 Chris Dumez 2018-07-12 08:30:32 PDT
Comment on attachment 344843 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2018-07-12 09:02:18 PDT
Comment on attachment 344843 [details]
Patch

Clearing flags on attachment: 344843

Committed r233769: <https://trac.webkit.org/changeset/233769>
Comment 7 WebKit Commit Bot 2018-07-12 09:02:20 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-07-12 09:03:26 PDT
<rdar://problem/42123360>