Bug 18756

Summary: Fix dependency problem in --clean
Product: WebKit Reporter: Robin Dunn <robin>
Component: WebKit wxAssignee: Kevin Ollivier <kevino>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
patch for build-wxwebkit mjs: review+

Robin Dunn
Reported 2008-04-26 13:33:59 PDT
On Windows when doing a --clean of a wx build then the derived sources directories get deleted before the makefile clean target is processed. Since it has some dependencies on the derived sources then the make fails. This patch simple reverses the order things are done. It also moves the _webview.dll to _webview.pyd.
Attachments
patch for build-wxwebkit (1.55 KB, patch)
2008-04-26 13:35 PDT, Robin Dunn 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robin Dunn
Comment 1 2008-04-26 13:35:19 PDT
Created attachment 20832 [details] patch for build-wxwebkit
Kevin Ollivier
Comment 2 2008-04-26 19:32:43 PDT
landed in r32600, thanks! :)
Maciej Stachowiak
Comment 3 2008-04-27 22:23:40 PDT
Comment on attachment 20832 [details] patch for build-wxwebkit Retroactive r+ since this was landed.
Note You need to log in before you can comment on or make changes to this bug.