Bug 187526

Summary: Remove unnecessary Test262 harness file and implement $262.IsHTMLDDA
Product: WebKit Reporter: Rick Waldron <rwaldron>
Component: Tools / TestsAssignee: Alexey Shvayka <ashvayka>
Status: RESOLVED FIXED    
Severity: Enhancement CC: ashvayka, darin, ews-watchlist, keith_miller, lforschler, mark.lam, msaboff, ross.kirsling, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=210078
https://bugs.webkit.org/show_bug.cgi?id=210470
Attachments:
Description Flags
patch
none
Patch
none
Patch none

Rick Waldron
Reported 2018-07-10 10:14:28 PDT
The functionality provided by this file is built-in. I confirmed this by: - Building JSC with a patch that enables SharedArrayBuffer and Atomics (https://gist.github.com/rwaldron/89ed9a4bb7a459db8d54c8fe77ead4b1) - Removing SharedArrayBuffer and Atomics from the skip list - Running the Atomics tests from Test262/master with agent.js: 342 tests run 59 test files skipped 27 tests failed in total 27 tests newly fail 0 tests newly pass Saved all the results in /Users/rwaldron/clonez/WebKit/test262-results/results.yaml Summarizing results... See the summaries and results in the /Users/rwaldron/clonez/WebKit/test262-results. Done in 13.48 seconds! without agent.js: 342 tests run 59 test files skipped 27 tests failed in total 27 tests newly fail 0 tests newly pass Saved all the results in /Users/rwaldron/clonez/WebKit/test262-results/results.yaml Summarizing results... See the summaries and results in the /Users/rwaldron/clonez/WebKit/test262-results. Done in 13.21 seconds!
Attachments
patch (4.09 KB, patch)
2018-07-10 10:48 PDT, Rick Waldron 		no flags
DetailsFormatted DiffDiff
Patch (8.41 KB, patch)
2020-04-05 13:45 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Patch (11.52 KB, patch)
2020-04-06 04:09 PDT, Alexey Shvayka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Rick Waldron
Comment 1 2018-07-10 10:48:51 PDT
Created attachment 344708 [details] patch
Alexey Shvayka
Comment 2 2020-04-05 13:45:33 PDT
Created attachment 395524 [details] Patch
Alexey Shvayka
Comment 3 2020-04-05 13:56:47 PDT
$262.IsHTMLDDA tests test/annexB/language/expressions/yield/star-iterable-return-emulates-undefined-throws-when-called.js test/annexB/language/statements/for-await-of/iterator-close-return-emulates-undefined-throws-when-called.js test/annexB/language/statements/for-of/iterator-close-return-emulates-undefined-throws-when-called.js are still failing because JSC partly implements https://github.com/tc39/ecma262/pull/1408.
Ross Kirsling
Comment 4 2020-04-05 17:35:26 PDT
This works, but I wonder if it would be better to make Masquerader callable -- seems like this is an omission that just wasn't necessary until now?
Alexey Shvayka
Comment 5 2020-04-06 04:09:59 PDT
Created attachment 395557 [details] Patch Return callable masquerader.
Alexey Shvayka
Comment 6 2020-04-06 04:18:04 PDT
(In reply to Ross Kirsling from comment #4) > This works, but I wonder if it would be better to make Masquerader callable > -- seems like this is an omission that just wasn't necessary until now? That is an awesome improvement, thank you. I thought there are quite a few tests for non-callable masquerader, yet is seems like one assertion only. Given that there is only one masquerader in the wild, and it is callable, we would rather use JSFunction::createFunctionThatMasqueradesAsUndefined.
EWS
Comment 7 2020-04-06 12:02:01 PDT
Committed r259587: <https://trac.webkit.org/changeset/259587> All reviewed patches have been landed. Closing bug and clearing flags on attachment 395557 [details].
Radar WebKit Bug Importer
Comment 8 2020-04-06 12:03:21 PDT
<rdar://problem/61352863>
Note You need to log in before you can comment on or make changes to this bug.