Bug 187517

Summary: [GLIB] Add API to allow creating variadic functions
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, ews-watchlist, keith_miller, mark.lam, mcatanzaro, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: Gtk, InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
mcatanzaro: review+
Archive of layout-test-results from ews205 for win-future none

Carlos Garcia Campos
Reported 2018-07-10 06:35:25 PDT
Our current API requires to know in advance the type and number of parameters of functions, methods and constructors. So, it's not possible to expose a function, method or constructor that can receive different amount of parameters.
Attachments
Patch (32.85 KB, patch)
2018-07-10 06:41 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
Archive of layout-test-results from ews205 for win-future (12.79 MB, application/zip)
2018-07-10 08:42 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2018-07-10 06:41:25 PDT
Created attachment 344691 [details] Patch
EWS Watchlist
Comment 2 2018-07-10 08:42:14 PDT
Comment on attachment 344691 [details] Patch Attachment 344691 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8494726 New failing tests: http/tests/security/canvas-remote-read-remote-video-redirect.html http/tests/security/contentSecurityPolicy/video-redirect-allowed.html
EWS Watchlist
Comment 3 2018-07-10 08:42:26 PDT
Created attachment 344698 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Michael Catanzaro
Comment 4 2018-07-11 06:36:34 PDT
Comment on attachment 344691 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344691&action=review > Source/JavaScriptCore/API/glib/JSCClass.cpp:645 > + * This function creates the constructor, that needs to be added to an object as a property to be able to use it. Use that -> which
Carlos Garcia Campos
Comment 5 2018-07-11 22:18:35 PDT
Committed r233760: <https://trac.webkit.org/changeset/233760>
Radar WebKit Bug Importer
Comment 6 2018-07-11 22:20:09 PDT
<rdar://problem/42104190>
Note You need to log in before you can comment on or make changes to this bug.