Bug 187482

Summary: Web Inspector: REGRESSION (r217505): Debugger content view doesn't update when left sidebar is collapsed
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Matt Baker
Reported 2018-07-09 14:12:24 PDT
Summary: Debugger content view doesn't update when left sidebar is collapsed. Steps to Reproduce (A): 1. Inspect webkit.org 2. Open Debugger tab 3. Collapse left sidebar 4. Select a new resource using the hierarchical path component in the content view's navigation bar => Selection does not change Steps to Reproduce (B): 1. Inspect webkit.org 2. Open Debugger tab 3. Set a breakpoint in global.js 4. Switch to another resource in the Debugger tab (like wp-embed-min.js) 5. Collapse left sidebar 6. Reload inspected page => Pause in debugger, but the content view doesn't change to show the pause location
Attachments
Patch (4.87 KB, patch)
2018-07-09 23:18 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-07-09 14:13:30 PDT
<rdar://problem/41989190>
Matt Baker
Comment 2 2018-07-09 16:58:20 PDT
This regressed in http://trac.webkit.org/changeset/217505.
Matt Baker
Comment 3 2018-07-09 17:02:11 PDT
The regression also broke navigating via the hierarchical path for Storage, Search, and Resources.
Matt Baker
Comment 4 2018-07-09 17:23:53 PDT
(In reply to Matt Baker from comment #3) > The regression also broke navigating via the hierarchical path for Storage, > Search, and Resources. Actually, StorageSidebarPanel._treeSelectionDidChange included the visible check prior to http://trac.webkit.org/changeset/217505.
Matt Baker
Comment 5 2018-07-09 23:18:14 PDT
Created attachment 344671 [details] Patch
Blaze Burg
Comment 6 2018-07-10 09:17:49 PDT
Comment on attachment 344671 [details] Patch r=me
WebKit Commit Bot
Comment 7 2018-07-10 09:44:52 PDT
Comment on attachment 344671 [details] Patch Clearing flags on attachment: 344671 Committed r233686: <https://trac.webkit.org/changeset/233686>
WebKit Commit Bot
Comment 8 2018-07-10 09:44:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.